Skip to content

[backend] feat(audit-logging): improv properties (#5480)#5923

Open
RomuDeuxfois wants to merge 1 commit into
mainfrom
issue/5480-improv-properties
Open

[backend] feat(audit-logging): improv properties (#5480)#5923
RomuDeuxfois wants to merge 1 commit into
mainfrom
issue/5480-improv-properties

Conversation

@RomuDeuxfois
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 24, 2026 19:00
@github-actions github-actions Bot added the filigran team use to identify PR from the Filigran team label May 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors audit logging configuration by introducing a new AuditLogProperties component and updating default properties to use a unified enabled/transports/include-reads scheme.

Changes:

  • Replaced legacy audit log property keys in application.properties with openaev.audit-logs.enabled, openaev.audit-logs.transports, and openaev.audit-logs.include-reads.
  • Added AuditLogProperties to load/validate the new audit logging settings.
  • Updated AuditRequestValidator to use AuditLogProperties for read-audit inclusion logic.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
openaev-api/src/main/resources/application.properties Switches audit logging configuration to the new unified keys and removes the API logging block.
openaev-api/src/main/java/io/openaev/config/audit_log/AuditLogProperties.java New component to represent/validate audit logging enablement and transport selection.
openaev-api/src/main/java/io/openaev/aop/audit_log/AuditRequestValidator.java Uses the new properties object for deciding whether READ/SEARCH should be audited.

Comment thread openaev-api/src/main/resources/application.properties
Comment thread openaev-api/src/main/resources/application.properties
@RomuDeuxfois RomuDeuxfois force-pushed the issue/5480-improv-properties branch from d09b712 to bd646b0 Compare May 24, 2026 19:20
@RomuDeuxfois RomuDeuxfois changed the title [backend] feat(audit-logging): improv properties [backend] feat(audit-logging): improv properties (#5480) May 24, 2026
@RomuDeuxfois RomuDeuxfois requested a review from Copilot May 24, 2026 20:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

openaev-api/src/main/java/io/openaev/utils/log/transport/AuditESLogTransportUtils.java:38

  • issue (critical): The new engine transport path relies on engineService.indexDocument(...), but the current EngineService only provides a default implementation that throws UnsupportedOperationException, and neither OpenSearchService nor ElasticService override it. Enabling the engine transport will therefore always fail to index audit events. Either implement indexDocument in the concrete engine services, or change this transport to use an existing indexing API that is supported by both engines.
  @Override
  public boolean isEnabled() {
    return auditLogProperties.isTransportEnabled(AuditLogProperties.TRANSPORT_ENGINE);
  }

  private static final String AUDIT_LOG_INDEX = "audit-log";

  private final EngineService engineService;
  private final EngineConfig engineConfig;

Comment thread openaev-api/src/main/resources/application.properties
Comment thread openaev-api/src/main/resources/application.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants