[backend] feat(inject): rename SUCCESS execution status to EXECUTED (#5643)#5950
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the inject/trace execution “success” statuses from SUCCESS to EXECUTED across the backend and frontend, adds alias-aware parsers to accept legacy values, and introduces a Flyway migration intended to update existing persisted status values.
Changes:
- Backend: rename enums/logic from
SUCCESS→EXECUTEDand addfromName()parsing for legacy status strings. - Frontend: update status labels/colors and regenerate API TypeScript types to reflect the new status names (while keeping some legacy UI aliases).
- Tests/migration: update test fixtures/assertions and add a DB migration to rewrite existing status strings.
Reviewed changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| openaev-model/src/main/java/io/openaev/database/model/InjectTestStatus.java | Switches success counting to EXECUTED (but needs broader success handling). |
| openaev-model/src/main/java/io/openaev/database/model/ExecutionTraceStatus.java | Renames success trace statuses and adds alias-aware parsing. |
| openaev-model/src/main/java/io/openaev/database/model/ExecutionTrace.java | Updates “success trace” factory methods to emit EXECUTED. |
| openaev-model/src/main/java/io/openaev/database/model/ExecutionStatus.java | Renames inject-level success to EXECUTED and adds alias-aware parsing. |
| openaev-model/src/main/java/io/openaev/database/model/Execution.java | Updates logging and aggregate status computation to use EXECUTED (but currently too narrow). |
| openaev-front/src/utils/statusUtils.ts | Adds color/style mapping for EXECUTED and keeps legacy aliases. |
| openaev-front/src/utils/statusLabels.ts | Adds user-facing labels/tooltips for EXECUTED and legacy aliases. |
| openaev-front/src/utils/api-types.d.ts | Regenerates API union types to use EXECUTED/EXECUTED_WITH_CLEANUP_FAILURE. |
| openaev-dev/Frontend start.run.xml | Updates IDE run configuration to pass --host and enable browser debugging. |
| openaev-api/src/test/java/io/openaev/utils/fixtures/InjectTestStatusFixture.java | Updates fixture to use ExecutionStatus.EXECUTED. |
| openaev-api/src/test/java/io/openaev/utils/fixtures/InjectStatusFixture.java | Updates fixture to use ExecutionStatus.EXECUTED. |
| openaev-api/src/test/java/io/openaev/utils/ExecutionTraceUtilsTest.java | Updates expected trace statuses to EXECUTED*. |
| openaev-api/src/test/java/io/openaev/service/InjectSearchServiceTest.java | Updates status assertion to EXECUTED. |
| openaev-api/src/test/java/io/openaev/service/InjectExpectationServiceTest.java | Updates injected trace status to EXECUTED. |
| openaev-api/src/test/java/io/openaev/service/chaining/WorkflowTimeoutServiceTest.java | Updates finished inject status to EXECUTED. |
| openaev-api/src/test/java/io/openaev/service/chaining/StepServiceIntegrationTest.java | Updates trace status to EXECUTED. |
| openaev-api/src/test/java/io/openaev/scheduler/jobs/InjectsExecutionJobTest.java | Updates expected computed final status to EXECUTED. |
| openaev-api/src/test/java/io/openaev/rest/inject/service/InjectorExecutionProcessingHandlerTest.java | Updates trace status inputs to EXECUTED. |
| openaev-api/src/test/java/io/openaev/rest/inject/service/AgentExecutionProcessingHandlerTest.java | Updates trace status inputs to EXECUTED. |
| openaev-api/src/test/java/io/openaev/rest/inject/InjectApiTest.java | Updates assertions/expected trace statuses to EXECUTED. |
| openaev-api/src/test/java/io/openaev/database/helper/ExecutionTraceRepositoryHelperTest.java | Updates persisted/updated status expectations to EXECUTED. |
| openaev-api/src/test/java/io/openaev/api/chaining/InjectExecutionStepTest.java | Updates trace status to EXECUTED. |
| openaev-api/src/main/java/io/openaev/utils/InjectStatusUtils.java | Updates computed inject status to return EXECUTED and ignores more non-actionable traces. |
| openaev-api/src/main/java/io/openaev/utils/ExecutionTraceUtils.java | Renames computed cleanup-failure success status to EXECUTED_WITH_CLEANUP_FAILURE. |
| openaev-api/src/main/java/io/openaev/scheduler/jobs/ComchecksExecutionJob.java | Updates success trace filtering to EXECUTED. |
| openaev-api/src/main/java/io/openaev/rest/inject/service/InjectStatusService.java | Uses ExecutionStatus.fromName() / ExecutionTraceStatus.fromName() for backward-compatible parsing. |
| openaev-api/src/main/java/io/openaev/rest/inject/service/InjectService.java | Updates “executed” inject status filter list to include EXECUTED. |
| openaev-api/src/main/java/io/openaev/rest/inject/service/ExecutionProcessingContext.java | Updates isSuccess() to use alias-aware parsing and success classification. |
| openaev-api/src/main/java/io/openaev/rest/atomic_testing/form/ExecutionTraceOutput.java | Updates schema example values to EXECUTED. |
| openaev-api/src/main/java/io/openaev/migration/V5_10__Rename_Execution_Statuses.java | Adds migration intended to rewrite legacy status strings in DB (currently has blocking issues). |
Comments suppressed due to low confidence (1)
openaev-model/src/main/java/io/openaev/database/model/Execution.java:62
- issue:
addTrace()logs anything that's not exactlyEXECUTED(orINFO) as an error. That includesWARNING,ACCESS_DENIED, andEXECUTED_WITH_CLEANUP_FAILURE, which are explicitly treated as success statuses inExecutionTraceStatus.SUCCESS_STATUSES. This will create misleading error logs.
ExecutionTraceStatus status = context.getStatus();
if (ExecutionTraceStatus.EXECUTED.equals(status) || ExecutionTraceStatus.INFO.equals(status)) {
log.info(context.getMessage());
} else {
log.error(context.getMessage());
}
84c64d0 to
548703d
Compare
antoinemzs
reviewed
May 27, 2026
548703d to
3b61cea
Compare
antoinemzs
reviewed
May 28, 2026
4db0a80 to
5a13bd8
Compare
5a13bd8 to
6afdb67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps
Go to Execution details tab → verify the trace status shows EXECUTED (not SUCCESS)
Run an Inject where cleanup fails
Trigger a scenario where cleanup is blocked (e.g., lock the artifact file)
Verify trace shows EXECUTED WITH CLEANUP FAIL
Check deprecated statuses are gone
Confirm MAYBE PREVENTED and MAYBE PARTIAL PREVENTED no longer appear anywhere in the UI
Expected result
No SUCCESS label visible anywhere in the execution UI — only EXECUTED and EXECUTED WITH CLEANUP FAIL.
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...