chore(agents): add migration-reviewer, sync shared exceptions, add agent-improvement workflow

[RomuDeuxfois]

What

Amélioration de l'outillage des agents de code OpenAEV.

Nouveaux fichiers

• .github/agents/migration-reviewer.agent.md — nouvel agent dédié aux migrations Flyway (manquant alors que migration.instructions.md existe depuis le début)
• .github/skills/review-migration/SKILL.md — skill step-by-step associé (naming, idempotency, tenant isolation, data safety, ES reindex)

Fichiers modifiés

• .github/AGENTS.md — 3 ajouts :
  1. Routing migration-reviewer dans la table de routing (signal: fichiers dans openaev-api/src/main/java/io/openaev/migration/)
  2. Section ## Shared Exceptions — liste centralisée des patterns à ne PAS flaguer, synchronisée entre tous les agents (était dupliquée et désynchronisée dans chaque What NOT to Flag)
  3. Model policy — Opus pour security/tenancy/migration, Sonnet pour le reste

À faire manuellement (permissions manquantes)

• .github/agents/WORKFLOW_TO_ADD.md contient le YAML complet du workflow agent-improvement.yml à créer dans .github/workflows/
• Ce workflow déclenche Copilot sur chaque PR pour :
  • Vérifier la cohérence des fichiers agents modifiés
  • Détecter les nouveaux patterns de code non couverts par les agents existants

Why

• Les migrations Flyway sont irréversibles en production — elles méritaient un agent dédié
• Les listes What NOT to Flag étaient dupliquées et risquaient de diverger (ex: FetchType.EAGER sur capabilities documenté dans security mais pas dans performance)
• Pas de mécanisme pour améliorer les agents au fil des PRs — les agents stagnent

Checklist

• migration-reviewer couvre : naming, class structure, idempotency, tenant isolation, data safety, ES reindex
• AGENTS.md routing inclut migration-reviewer avec le bon signal
• Shared exceptions centralisées et cohérentes avec les What NOT to Flag existants
• Model policy alignée avec copilot-instructions.md
• Workflow agent-improvement.yml à créer manuellement (voir WORKFLOW_TO_ADD.md)

[github-actions]

Thank you for your contribution. This PR is but one step away from being ready for merging: all commits must be PGP-signed. To get started, please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[Copilot]

Pull request overview

This PR improves OpenAEV’s GitHub Copilot agent/tooling documentation by adding a dedicated migration reviewer (agent + skill), aligning reviewer agents on “shared exceptions” and model policy guidance, and providing a ready-to-copy workflow draft intended to continuously validate/upgrade agent coverage on PRs.

Changes:

• Add migration review capability via migration-reviewer agent and review-migration skill.
• Introduce/extend model policy + responsibility-boundary guidance across multiple reviewer agents (security, perf, tenancy, frontend, tests).
• Add an “Agent Improvement” workflow template (manual step) and a new/expanded .github/AGENTS.md entry point with routing + shared exceptions.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
.github/skills/review-migration/SKILL.md	New step-by-step migration review skill (naming/idempotency/tenancy/data safety/ES reindex).
.github/agents/WORKFLOW_TO_ADD.md	Draft GitHub Actions workflow YAML to comment on PRs for agent consistency/coverage checks.
.github/agents/test-specialist.agent.md	Adds model policy + explicit boundary with multi-tenancy reviewer for tenant isolation tests.
.github/agents/security-reviewer.agent.md	Adds model policy and expands “What NOT to Flag” list to align with shared exceptions.
.github/agents/performance-reviewer.agent.md	Adds model policy and updates “What NOT to Flag” with shared exceptions.
.github/agents/multi-tenancy-reviewer.agent.md	Adds model policy + boundary section and updates “What NOT to Flag”.
.github/agents/migration-reviewer.agent.md	New migration-focused agent with procedure, rubric, and output format.
.github/agents/frontend-reviewer.agent.md	Adds model policy + quantitative thresholds and shared exception for generated API types.
.github/agents/api-reviewer.agent.md	New API-focused reviewer agent (controllers/DTOs/swagger/breaking changes).
.github/AGENTS.md	Central agent entry point: routing table, shared exceptions list, model policy, anti-patterns.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.78%. Comparing base (98e4192) to head (9ca5057).
⚠️ Report is 1 commits behind head on main.

❌ Your project check has failed because the head coverage (2.96%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6363      +/-   ##
============================================
- Coverage     43.81%   43.78%   -0.04%     
+ Complexity     7043     7040       -3     
============================================
  Files          2254     2254              
  Lines         62116    62116              
  Branches       8183     8183              
============================================
- Hits          27216    27197      -19     
- Misses        33166    33184      +18     
- Partials       1734     1735       +1     

Flag	Coverage Δ
backend	66.13% <ø> (-0.02%)	⬇️
e2e	18.31% <ø> (-0.41%)	⬇️
frontend	2.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[RomuDeuxfois]

@copilot fix tous les commentaires

[Copilot]

@copilot fix tous les commentaires

C’est fait dans le commit e392392.

Correctifs appliqués :

• patterns de migration corrigés en V{Y}_{XX}__*.java dans review-migration/SKILL.md et migration-reviewer.agent.md
• exemple SQL corrigé en indexing_status_type (au lieu de index_id)
• routage AGENTS.md complété avec API Reviewer et Migration Reviewer (+ skill review-migration).

[laugiov]

I may have missed something, but the shared exceptions look only half wired up. Four agents (api, frontend, multi-tenancy, performance) still keep their own full "What NOT to Flag" list instead of pointing to the shared one, and some items are duplicated. Could we make them reference the shared section too, so they don't drift apart over time?

[laugiov]

Heads up: PR #6316 changes the migration naming format. The new review-migration skill still checks for a "next sequential number, no gaps", and the rubric flags a "sequence gap".
With the new format those checks would flag valid migrations as wrong.
If #6316 lands, Step 2 and the "sequence gap" rule would need an update. The rest of the skill (idempotency, tenant isolation, data safety, ES reindex) stays valid.

[RomuDeuxfois]

Thanks for the feedbacks. I will wait the merge of PR 6316 then.

[antoinemzs]

Thanks for the feedbacks. I will wait the merge of PR 6316 then.

the migrations change is merged now, thanks for your patience wrt this matter

[RomuDeuxfois]

@copilot PR 6316 is merged, changes the according .md files.

[Copilot]

@copilot PR 6316 is merged, changes the according .md files.

Updated in commit 85ab8b8.

I aligned the migration review markdown files with the post-#6316 format:

• removed sequential/no-gap checks from the migration skill
• switched naming checks to V{major}_{yyyyMMddHHmmssSSS}__{description} with timestamp/uniqueness validation
• updated migration-reviewer rubric/procedure/output placeholders to match the new format.