fix(engine): fix ES indexing cursor skipping expectations with same timestamp (#6490)

[Seb-MIGUEL]

Problem

The custom dashboard shows 100% detected for some injects. Clicking opens a drawer with inject_expectation_status = SUCCESS from Elasticsearch. Clicking an inject navigates to the inject detail page which shows 100% not detected — inconsistent data between ES and DB.

Fixes #6490

Root Cause

findForIndexing uses a strict > comparison on updated_at:

WHERE inject_expectation_updated_at > :from
ORDER BY inject_expectation_updated_at ASC
LIMIT 500

When bulkComputeTechnicalExpectations expires hundreds of expectations in one saveAll() call, Hibernate's @UpdateTimestamp assigns the same millisecond to all of them. If there are >500 with the same timestamp, the indexing cursor advances to T, then updated_at > T permanently skips the rest.

Fix: Compound keyset cursor

Add a secondary inject_expectation_id cursor so the query can resume within a timestamp:

WHERE (inject_expectation_updated_at > :from)
   OR (inject_expectation_updated_at = :from AND inject_expectation_id > :lastId)
ORDER BY inject_expectation_updated_at ASC, inject_expectation_id ASC

Changes

File	Change
V5_35__Add_indexing_last_id.java	Migration: add indexing_last_id TEXT NULL to indexing_status
IndexingStatus.java	Add lastId field for compound cursor
InjectExpectationRepository.java	Add findForIndexingAfter(from, lastId, limit) query
Handler.java	Add default fetch(from, lastId, limit) method (backward-compatible)
InjectExpectationHandler.java	Override compound-cursor fetch + extract shared mapping helper
OpenSearchService.java	Track lastId in bulkProcessing, pass to handler
ElasticService.java	Same as OpenSearch

Cursor logic

• Full batch returned (size == 500): save lastId = lastItem.id, keep same lastIndexing
• Partial batch (size < 500): clear lastId = null, advance lastIndexing as before

[Copilot]

Pull request overview

This PR aims to prevent Elasticsearch/OpenSearch indexing from permanently skipping InjectExpectation updates when more than one batch shares the same updated_at timestamp, by introducing a compound keyset cursor (updated_at, id) and persisting the secondary cursor (lastId) in indexing_status.

Changes:

• Add indexing_last_id to indexing_status and expose it via IndexingStatus to support compound cursor persistence.
• Thread lastId through ElasticService/OpenSearchService bulk processing and use the new Handler.fetch(from, lastId, limit) API.
• Add a new compound-cursor native query for inject expectation indexing and update InjectExpectationHandler to use it.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
openaev-model/src/main/java/io/openaev/service/OpenSearchService.java	Passes lastId into handler fetch and persists it in indexing status for full batches.
openaev-model/src/main/java/io/openaev/service/ElasticService.java	Mirrors OpenSearch changes: compound cursor threading + persistence.
openaev-model/src/main/java/io/openaev/engine/model/injectexpectation/InjectExpectationHandler.java	Adds compound-cursor fetch implementation for inject expectations (currently contains a blocking duplicate class declaration).
openaev-model/src/main/java/io/openaev/engine/Handler.java	Adds backward-compatible default fetch(from, lastId, limit) method for handlers.
openaev-model/src/main/java/io/openaev/database/repository/InjectExpectationRepository.java	Introduces findForIndexingAfter(from, lastId, limit) with compound cursor ordering.
openaev-model/src/main/java/io/openaev/database/model/IndexingStatus.java	Adds lastId field mapped to indexing_last_id.
openaev-api/src/main/java/io/openaev/migration/V5_35__Add_indexing_last_id.java	Flyway migration adding indexing_last_id column to indexing_status.
openaev-api/src/main/java/io/openaev/integration/IntegrationFactory.java	Adds ensureCatalogLogo() hook and runs it best-effort when catalog entry already exists.
openaev-api/src/main/java/io/openaev/integration/impl/injectors/ovh/OvhInjectorIntegrationFactory.java	Refactors logo upload into ensureCatalogLogo() + shared filename helper.
openaev-api/src/main/java/io/openaev/integration/impl/injectors/opencti/OpenCTIInjectorIntegrationFactory.java	Refactors logo upload into ensureCatalogLogo() + shared filename helper.
openaev-api/src/main/java/io/openaev/integration/impl/executors/tanium/TaniumExecutorIntegrationFactory.java	Refactors logo upload into ensureCatalogLogo() + shared filename helper.
openaev-api/src/main/java/io/openaev/integration/impl/executors/sentinelone/SentinelOneExecutorIntegrationFactory.java	Refactors logo upload into ensureCatalogLogo() + shared filename helper.
openaev-api/src/main/java/io/openaev/integration/impl/executors/paloaltocortex/PaloAltoCortexExecutorIntegrationFactory.java	Refactors logo upload into ensureCatalogLogo() + shared filename helper.
openaev-api/src/main/java/io/openaev/integration/impl/executors/crowdstrike/CrowdStrikeExecutorIntegrationFactory.java	Refactors logo upload into ensureCatalogLogo() + shared filename helper.
openaev-api/src/main/java/io/openaev/integration/impl/executors/caldera/CalderaExecutorIntegrationFactory.java	Refactors logo upload into ensureCatalogLogo() + shared filename helper.
openaev-api/src/test/java/io/openaev/integration/local_fixtures/regular/TestIntegrationFactory.java	Updates test factory to use ensureCatalogLogo() and shared logo filename helper.
openaev-api/src/test/java/io/openaev/integration/local_fixtures/factory_throws/TestIntegrationFactoryInitThrows.java	Same refactor for the throwing factory test fixture.
.github/skills/review-code/SKILL.md	Updates review skill documentation with additional anti-pattern checks.

[Seb-MIGUEL]

Closing: la branche incluait les commits de PR #6475 (InjectorFactory). Remplacé par une PR propre depuis main.