Enhance rpmsg buf config#684
Open
tnmysh wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
we can review this one after the release. |
tnmysh
force-pushed
the
enhance_rpmsg_buf_config
branch
2 times, most recently
from
7310369 to
3474c42
Compare
tnmysh
force-pushed
the
enhance_rpmsg_buf_config
branch
from
3474c42 to
6ddcf11
Compare
Introduce new feature bit that allows rpmsg buffer size via virtio device config space. If the feature is available then, driver will set single rpmsg buffer size from virtio device config space in the resource table. New virtio feature allows to configure rpmsg single buffer size via virtio device config space. Hence, rx buffer size can be provided by vdev device config space as well. If BUFSZ feature bit is set, then use rx buffer size from the virtio config space in the resource table. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
tnmysh
force-pushed
the
enhance_rpmsg_buf_config
branch
from
6ddcf11 to
7c0b658
Compare
arnopo
requested changes
Jun 2, 2026
| return status; | ||
|
|
||
| if (features & (1 << VIRTIO_RPMSG_F_BUFSZ)) | ||
| rvdev->config = *config; |
Collaborator
There was a problem hiding this comment.
Here you should use virtio_read_config to retrieve the config from the transport layer
Did you have a look to @xiaoxiang781216 work in #155 ?
Seems to me the good approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding Linux kernel patch series: https://lore.kernel.org/all/20251114184640.3020427-1-tanmay.shah@amd.com/