refactor: make sourceFilters and generatedMetadataCache mandatory in transformQraftTreeShaking

Author: radist2s

packages/tree-shaking-plugin/src/__tests__/core/harness.ts

@@ -4,6 +4,7 @@ import fs from 'node:fs/promises';
 import os from 'node:os';
 import path from 'node:path';
 import { transformQraftTreeShaking as transformQraftTreeShakingImpl } from '../../core.js';
+import { createGeneratedMetadataCache } from '../../lib/transform/generated-metadata.js';
 import { createTransformState } from '../../lib/transform/state.js';
 import {
   createFixtureModuleAccess,
@@ -32,6 +33,8 @@ export async function transformQraftTreeShaking(
   const moduleAccess = createFixtureModuleAccess(fixtureRoot, {
     resolve: options.moduleAccess?.resolve ?? options.resolve,
   });
+  const generatedMetadataCache = createGeneratedMetadataCache();
+  const sourceFilters = {};
 
   if (options.moduleAccess?.load) {
     return transformQraftTreeShakingImpl(
@@ -42,7 +45,9 @@ export async function transformQraftTreeShaking(
         ...moduleAccess,
         load: options.moduleAccess.load,
       },
-      inputSourceMap
+      inputSourceMap,
+      generatedMetadataCache,
+      sourceFilters
     );
   }
 
@@ -51,7 +56,9 @@ export async function transformQraftTreeShaking(
     id,
     options,
     moduleAccess,
-    inputSourceMap
+    inputSourceMap,
+    generatedMetadataCache,
+    sourceFilters
   );
 }
 

packages/tree-shaking-plugin/src/__tests__/core/resolution-and-module-access.test.ts

@@ -8,6 +8,7 @@ import {
   createUserResolverStrategy,
   createUserSourceLoaderStrategy,
 } from '../../lib/resolvers/common.js';
+import { createGeneratedMetadataCache } from '../../lib/transform/generated-metadata.js';
 import {
   createFixtureModuleAccess,
   PRECREATED_API_INDEX_TS,
@@ -179,7 +180,10 @@ createAPIClient().pets.getPets.useQuery();
             },
           ],
         },
-        moduleAccess
+        moduleAccess,
+        undefined,
+        createGeneratedMetadataCache(),
+        {}
       )
     ).rejects.toMatchObject({
       name: 'QraftTreeShakeError',
@@ -248,7 +252,10 @@ createAPIClient().pets.getPets.useQuery();
             },
           ],
         },
-        moduleAccess
+        moduleAccess,
+        undefined,
+        createGeneratedMetadataCache(),
+        {}
       )
     ).rejects.toMatchObject({
       name: 'QraftTreeShakeError',
@@ -686,7 +693,10 @@ export function App() {
         {
           resolve: fixtureResolver,
           load,
-        }
+        },
+        undefined,
+        createGeneratedMetadataCache(),
+        {}
       );
 
       expect(result).toBeNull();

packages/tree-shaking-plugin/src/core.ts

@@ -85,18 +85,18 @@ export async function transformQraftTreeShaking(
   id: string,
   options: QraftTreeShakeOptions,
   moduleAccess: QraftModuleAccess,
-  inputSourceMap?: SourceMapInput,
-  generatedMetadataCache?: GeneratedMetadataCache,
-  sourceFilters?: SourceFilterOptions
+  inputSourceMap: SourceMapInput | undefined,
+  generatedMetadataCache: GeneratedMetadataCache,
+  sourceFilters: SourceFilterOptions
 ) {
   const entrypoints = normalizeEntrypoints(options);
   if (
     !shouldInspectSource({
       code,
       id,
       entrypoints,
-      include: sourceFilters?.include,
-      exclude: sourceFilters?.exclude,
+      include: sourceFilters.include,
+      exclude: sourceFilters.exclude,
     })
   ) {
     return null;