fix: ensure resolveResponse always resolves promises.#331
Merged
Conversation
🦋 Changeset detectedLatest commit: c796132 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const mockResponse = new Response(null); | ||
|
|
||
| // We use casting to bypass type checking, since we know that the function accepts Response | ||
| // without promis in the implementation, although types do not allow it directly |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
radist2s
changed the title
resolveResponse always **resolves** promises.resolveResponse always *resolves* promises.
radist2s
changed the title
resolveResponse always *resolves* promises.resolveResponse always resolves promises.
This comment has been minimized.
This comment has been minimized.
radist2s
force-pushed
the
fix/resolve-response-fn
branch
from
b763062 to
c796132
Compare
radist2s
force-pushed
the
fix/resolve-response-fn
branch
from
9a1e91c to
b763062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the
resolveResponsefunction to always return a resolved Promiserather than rejecting when no
responsePromiseis provided. This brings the function'sbehavior in line with the
requestFnpattern, ensuring consistent error handling.