Skip to content

Build as multi release jar #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 9 commits into from
Oct 4, 2025
Merged

Build as multi release jar #62

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8275f8d
Build as multi release jar
Til7701 Apr 4, 2025
b8e54d7
Merge remote-tracking branch 'original/master' into module-2
Til7701 Sep 23, 2025
124ee51
Update Java Version in maven test Action
Til7701 Sep 23, 2025
1524d09
Add service providers to module info
Til7701 Sep 23, 2025
ffc42f8
Use release instead of source and target
Til7701 Sep 24, 2025
0febe91
Merge remote-tracking branch 'original/master' into module-2
Til7701 Sep 24, 2025
2045f8a
Merge remote-tracking branch 'original/master' into module-2
Til7701 Sep 24, 2025
2ba06f2
Merge remote-tracking branch 'original/master' into module-2
Til7701 Sep 24, 2025
13537f4
Merge remote-tracking branch 'original/master' into module-2
Til7701 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/maven_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up JDK 8
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
java-version: 8
java-version: 11
distribution: 'temurin'
- name: Cache Maven packages
uses: actions/cache@v3
Expand All @@ -34,10 +34,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up JDK 8
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
java-version: 8
java-version: 11
distribution: 'temurin'
- name: Cache Maven packages
uses: actions/cache@v3
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Set up Maven Central Repository
uses: actions/setup-java@v3
with:
java-version: 8
java-version: 11
distribution: 'temurin'
server-id: central
server-username: MAVEN_USERNAME
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/maven_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up JDK 8
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
java-version: 8
java-version: 11
distribution: 'temurin'
- name: Cache Maven packages
uses: actions/cache@v3
Expand Down
32 changes: 27 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,32 @@
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.0</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
<executions>
<execution>
<id>compile-java-8</id>
<goals>
<goal>compile</goal>
</goals>
<configuration>
<source>1.8</source>
<target>1.8</target>
Copy link
Copy Markdown
Contributor

@nrayburn-tech nrayburn-tech Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of source/target, use release with 8.

Copy link
Copy Markdown
Contributor Author

@Til7701 Til7701 Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its practically identical, but you are right. It's a bit clearer that way.

Copy link
Copy Markdown
Contributor

@nrayburn-tech nrayburn-tech Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think release is meant to be a bit more robust in terms of ensuring backwards compatibility. I can’t say I actually know the difference other than release is typically used in newer Java versions.

</configuration>
</execution>
<execution>
<id>compile-java-9</id>
<phase>compile</phase>
<goals>
<goal>compile</goal>
</goals>
<configuration>
<release>9</release>
<compileSourceRoots>
<compileSourceRoot>${project.basedir}/src/main/java9</compileSourceRoot>
</compileSourceRoots>
<multiReleaseOutput>true</multiReleaseOutput>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand All @@ -93,7 +115,7 @@
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>org.openapitools.jackson.nullable</Automatic-Module-Name>
<Multi-Release>true</Multi-Release>
</manifestEntries>
</archive>
</configuration>
Expand Down
11 changes: 11 additions & 0 deletions src/main/java9/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
module org.openapitools.jackson.nullable {
requires com.fasterxml.jackson.databind;
requires static jakarta.validation;
requires static java.validation;
Copy link
Copy Markdown
Contributor

@nrayburn-tech nrayburn-tech Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work correctly in projects that only have the javax OR jakarta dependency? This project has both as a provided scope, so I expect tests/compile will pass. However an application/library that depends on this project will typically only have one or the other.

Sorry, I'm not super familiar with the module system.

Copy link
Copy Markdown
Contributor Author

@Til7701 Til7701 Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used this in one project when I first created the PR. That project is now suspended, but it worked with JLink at the time. I only hat the Jakarta namespace in that project.


exports org.openapitools.jackson.nullable;

provides com.fasterxml.jackson.databind.Module with org.openapitools.jackson.nullable.JsonNullableModule;
provides javax.validation.valueextraction.ValueExtractor with org.openapitools.jackson.nullable.JsonNullableValueExtractor;
provides jakarta.validation.valueextraction.ValueExtractor with org.openapitools.jackson.nullable.JsonNullableJakartaValueExtractor;
}