NullPointerException when oneOf changes to anyOf in response schema (#892)

Fixes #381

Author: DrSatyr

core/src/main/java/org/openapitools/openapidiff/core/compare/schemadiffresult/ComposedSchemaDiffResult.java

@@ -117,16 +117,18 @@ private Map<String, Schema> getSchema(
 
   private Map<String, String> getMapping(ComposedSchema composedSchema) {
     Map<String, String> reverseMapping = new LinkedHashMap<>();
-    for (Schema<?> schema : composedSchema.getOneOf()) {
-      String ref = schema.get$ref();
-      if (ref == null) {
-        continue;
-      }
-      String schemaName = refPointer.getRefName(ref);
-      if (schemaName == null) {
-        throw new IllegalArgumentException("invalid schema: " + ref);
+    if (composedSchema.getOneOf() != null) {
+      for (Schema<?> schema : composedSchema.getOneOf()) {
+        String ref = schema.get$ref();
+        if (ref == null) {
+          continue;
+        }
+        String schemaName = refPointer.getRefName(ref);
+        if (schemaName == null) {
+          throw new IllegalArgumentException("invalid schema: " + ref);
+        }
+        reverseMapping.put(ref, schemaName);
       }
-      reverseMapping.put(ref, schemaName);
     }
 
     if (composedSchema.getDiscriminator() != null

core/src/test/java/org/openapitools/openapidiff/core/OneOfDiffTest.java

@@ -18,6 +18,8 @@ public class OneOfDiffTest {
   private final String OPENAPI_DOC8 = "oneOf_discriminator-missing_1.yaml";
   private final String OPENAPI_DOC9 = "oneOf_discriminator-missing_2.yaml";
   private final String OPENAPI_DOC10 = "unnamed_oneof_schema_1.yaml";
+  private final String OPENAPI_DOC11 = "oneOf_to_anyOf_1.yaml";
+  private final String OPENAPI_DOC12 = "oneOf_to_anyOf_2.yaml";
 
   @Test
   public void testDiffSame() {
@@ -59,4 +61,9 @@ public void testOneOfDiscrimitatorMissingSameOrder() {
   public void testOneOfDiscrimitatorMissingDifferentOrder() {
     assertOpenApiAreEquals(OPENAPI_DOC8, OPENAPI_DOC9);
   }
+
+  @Test // issue #381
+  public void testOneOfToAnyOfDoesNotThrow() {
+    assertOpenApiChangedEndpoints(OPENAPI_DOC11, OPENAPI_DOC12);
+  }
 }

core/src/test/resources/oneOf_to_anyOf_1.yaml

@@ -0,0 +1,34 @@
+openapi: 3.0.1
+info:
+  title: oneOf to anyOf repro (old)
+  version: 1.0.0
+paths:
+  /example:
+    get:
+      responses:
+        "200":
+          description: ok
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/Result"
+components:
+  schemas:
+    Result:
+      oneOf:
+        - $ref: "#/components/schemas/TypeA"
+        - $ref: "#/components/schemas/TypeB"
+    TypeA:
+      type: object
+      required:
+        - a
+      properties:
+        a:
+          type: string
+    TypeB:
+      type: object
+      required:
+        - b
+      properties:
+        b:
+          type: string

core/src/test/resources/oneOf_to_anyOf_2.yaml

@@ -0,0 +1,34 @@
+openapi: 3.0.1
+info:
+  title: oneOf to anyOf repro (new)
+  version: 1.0.0
+paths:
+  /example:
+    get:
+      responses:
+        "200":
+          description: ok
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/Result"
+components:
+  schemas:
+    Result:
+      anyOf:
+        - $ref: "#/components/schemas/TypeA"
+        - $ref: "#/components/schemas/TypeB"
+    TypeA:
+      type: object
+      required:
+        - a
+      properties:
+        a:
+          type: string
+    TypeB:
+      type: object
+      required:
+        - b
+      properties:
+        b:
+          type: string