Propagate CLI subprocess exit code

[mxr]

Problem

The console script currently discards the return code from the Java subprocess. That means callers can see a successful Python CLI exit even when Java fails.

Solution

Exit from the console entry point with the subprocess return code. Add a regression test that verifies the CLI propagates a non-zero result.

---

Summary by cubic

Propagate the Java subprocess exit code from the openapi-generator-cli entrypoint so callers and CI fail correctly. cli now accepts argv and defaults to sys.argv to preserve behavior and simplify testing.

• Bug Fixes
  • Exit with the Java return code via sys.exit(run(args).returncode) and parse args as (argv or sys.argv)[1:].
  • Add tests for run([...]) and cli([...]) to assert non-zero exit codes, error message, and no stdout on invalid args.
  • Document the cli(argv) argument and default behavior in the docstring.

^{Written for commit 44495ec. Summary will update on new commits. Review in cubic}

[cubic-dev-ai]

No issues found across 2 files

[cubic-dev-ai]

2 issues found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/test_cli.py">

<violation number="1" location="tests/test_cli.py:48">
P2: Replacing the dedicated CLI exit-code test with another invalid-argument test drops coverage for `cli()` propagating `run(...).returncode`.</violation>
</file>

<file name="openapi_generator_cli/__init__.py">

<violation number="1" location="openapi_generator_cli/__init__.py:61">
P1: Console-script entry point will drop all user CLI arguments because `cli()` now falls back to `[]` when invoked without argv.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="openapi_generator_cli/__init__.py">

<violation number="1" location="openapi_generator_cli/__init__.py:61">
P2: `cli([])` now falls back to `sys.argv` instead of honoring the caller-provided empty argv, changing public API behavior and potentially propagating unrelated process arguments.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}