Skip to content

Commit 8ff22d1

Browse files
PicazsooCopilot
andcommitted
fix: restore node-version matrix dimension in 3 TypeScript workflows
samples-typescript-axios-echo-api.yaml samples-typescript-encode-decode.yaml samples-typescript-node-encode-decode.yaml Node version numbers (16, 18, 20, 22, 24) had leaked into all_samples as bare integer literals. compute-matrix treated them as fake sample paths, and the build matrix was replaced wholesale, dropping the node-version dimension and breaking matrix.node-version references. Fix mirrors the earlier Python workflow fix: - Remove version literals from all_samples - Switch setup output to samples (not matrix) - Add static node-version: dimension alongside sample: in build matrix - Update if: guard to check needs.setup.outputs.samples != '[]' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent b926c28 commit 8ff22d1

3 files changed

Lines changed: 24 additions & 18 deletions

File tree

.github/workflows/samples-typescript-axios-echo-api.yaml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
setup:
1111
runs-on: ubuntu-latest
1212
outputs:
13-
matrix: ${{ steps.filter.outputs.matrix }}
13+
samples: ${{ steps.filter.outputs.samples }}
1414
steps:
1515
- uses: actions/checkout@v5
1616
with:
@@ -23,18 +23,20 @@ jobs:
2323
# To add a new sample: add it here AND add a matching entry to the paths: trigger above.
2424
all_samples: |
2525
samples/client/echo_api/typescript-axios/test
26-
16
27-
18
28-
20
2926
3027
build:
3128
name: Test TypeScript Axios client
3229
needs: setup
33-
if: ${{ needs.setup.outputs.matrix != '[]' }}
30+
if: ${{ needs.setup.outputs.samples != '[]' }}
3431
runs-on: ubuntu-latest
3532
strategy:
3633
fail-fast: false
37-
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
34+
matrix:
35+
node-version:
36+
- 16
37+
- 18
38+
- 20
39+
sample: ${{ fromJson(needs.setup.outputs.samples) }}
3840
steps:
3941
- uses: actions/checkout@v5
4042

.github/workflows/samples-typescript-encode-decode.yaml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
setup:
1111
runs-on: ubuntu-latest
1212
outputs:
13-
matrix: ${{ steps.filter.outputs.matrix }}
13+
samples: ${{ steps.filter.outputs.samples }}
1414
steps:
1515
- uses: actions/checkout@v5
1616
with:
@@ -23,18 +23,20 @@ jobs:
2323
# To add a new sample: add it here AND add a matching entry to the paths: trigger above.
2424
all_samples: |
2525
samples/client/others/typescript/encode-decode/test
26-
20
27-
22
28-
24
2926
3027
build:
3128
name: Test TypeScript Encoding / Decoding
3229
needs: setup
33-
if: ${{ needs.setup.outputs.matrix != '[]' }}
30+
if: ${{ needs.setup.outputs.samples != '[]' }}
3431
runs-on: ubuntu-latest
3532
strategy:
3633
fail-fast: false
37-
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
34+
matrix:
35+
node-version:
36+
- 20
37+
- 22
38+
- 24
39+
sample: ${{ fromJson(needs.setup.outputs.samples) }}
3840
steps:
3941
- uses: actions/checkout@v5
4042

.github/workflows/samples-typescript-node-encode-decode.yaml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
setup:
1111
runs-on: ubuntu-latest
1212
outputs:
13-
matrix: ${{ steps.filter.outputs.matrix }}
13+
samples: ${{ steps.filter.outputs.samples }}
1414
steps:
1515
- uses: actions/checkout@v5
1616
with:
@@ -23,18 +23,20 @@ jobs:
2323
# To add a new sample: add it here AND add a matching entry to the paths: trigger above.
2424
all_samples: |
2525
samples/client/others/typescript-node/encode-decode/test
26-
16
27-
18
28-
20
2926
3027
build:
3128
name: Test TypeScript Node Encoding / Decoding
3229
needs: setup
33-
if: ${{ needs.setup.outputs.matrix != '[]' }}
30+
if: ${{ needs.setup.outputs.samples != '[]' }}
3431
runs-on: ubuntu-latest
3532
strategy:
3633
fail-fast: false
37-
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
34+
matrix:
35+
node-version:
36+
- 16
37+
- 18
38+
- 20
39+
sample: ${{ fromJson(needs.setup.outputs.samples) }}
3840
steps:
3941
- uses: actions/checkout@v5
4042

0 commit comments

Comments
 (0)