Fix child constructor no longer has invalid access to parent field (#23205)

* Fix fix that child constructor was invalid when having readonly field in parent

* add classType field

* fix test

* update samples

---------

Co-authored-by: bdurca <rca@bankdata.dk>

Author: wing328

modules/openapi-generator/src/main/resources/Java/libraries/microprofile/pojo.mustache

@@ -52,10 +52,10 @@ public class {{classname}} {{#parent}}extends {{{.}}}{{/parent}}{{#vendorExtensi
 {{{.}}}
 {{/vendorExtensions.x-field-extra-annotation}}
 {{#isContainer}}
-  private {{{datatypeWithEnum}}} {{name}}{{#required}} = {{{defaultValue}}}{{/required}}{{^required}} = null{{/required}};
+  protected {{{datatypeWithEnum}}} {{name}}{{#required}} = {{{defaultValue}}}{{/required}}{{^required}} = null{{/required}};
 {{/isContainer}}
 {{^isContainer}}
-  private {{{datatypeWithEnum}}} {{name}}{{#defaultValue}} = {{{.}}}{{/defaultValue}};
+  protected {{{datatypeWithEnum}}} {{name}}{{#defaultValue}} = {{{.}}}{{/defaultValue}};
 {{/isContainer}}
   {{/vars}}
 {{>additional_properties}}

modules/openapi-generator/src/test/java/org/openapitools/codegen/java/microprofile/JavaMicroprofileServerCodegenTest.java

@@ -235,5 +235,31 @@ public void testGeneratedApiExceptionMapperDoesNotHaveProviderAnnotationWhenDisa
                 .assertTypeAnnotations()
                 .doesNotContainWithName("Provider");
     }
+
+    @Test
+    public void testClientCanAccessFieldInParent() throws Exception {
+        File output = Files.createTempDirectory("test").toFile().getCanonicalFile();
+        output.deleteOnExit();
+
+        OpenAPI openAPI = new OpenAPIParser()
+                .readLocation("src/test/resources/bugs/issue_23034.yaml", null, new ParseOptions()).getOpenAPI();
+
+        codegen.setOutputDir(output.getAbsolutePath());
+        codegen.additionalProperties().put(JavaClientCodegen.MICROPROFILE_GLOBAL_EXCEPTION_MAPPER, "false");
+
+        ClientOptInput input = new ClientOptInput()
+                .openAPI(openAPI)
+                .config(codegen);
+
+        List<File> files = new DefaultGenerator().opts(input).generate();
+
+        Map<String, File> filesMap = files.stream()
+                .collect(Collectors.toMap(File::getName, Function.identity()));
+
+        validateJavaSourceFiles(files);
+
+        JavaFileAssert.assertThat(filesMap.get("Parent.java"))
+                .fileContains("protected String parentField;");
+    }
 }
 

modules/openapi-generator/src/test/resources/bugs/issue_23034.yaml

@@ -0,0 +1,47 @@
+---
+openapi: 3.0.4
+info:
+  title: Reproduce
+  version: 'v1'
+components:
+  schemas:
+    Child:
+      required:
+        - childField1
+      type: object
+      allOf:
+        - $ref: "#/components/schemas/Parent"
+      properties:
+        childField1:
+          type: string
+
+    Parent:
+      required:
+        - classType
+        - parentField
+      type: object
+      properties:
+        parentField:
+          type: string
+          readOnly: true
+        classType:
+          description: Identifier of discriminator mapping class.
+          enum:
+            - Child
+          type: string
+      discriminator:
+        propertyName: classType
+        mapping:
+          Child: "#/components/schemas/Child"
+paths:
+  '/v1/reproduce':
+    get:
+      responses:
+        '200':
+          content:
+            application/json:
+              schema:
+                type: array
+                items:
+                  $ref: '#/components/schemas/Child'
+          description: 'reproduce'

samples/client/petstore/java/microprofile-rest-client-3.0-jackson-mutiny/src/main/java/org/openapitools/client/model/Category.java

@@ -36,11 +36,11 @@ public class Category  {
 
   public static final String JSON_PROPERTY_ID = "id";
 
-  private Long id;
+  protected Long id;
 
   public static final String JSON_PROPERTY_NAME = "name";
 
-  private String name;
+  protected String name;
 
 
   /**

samples/client/petstore/java/microprofile-rest-client-3.0-jackson-mutiny/src/main/java/org/openapitools/client/model/ModelApiResponse.java

@@ -38,15 +38,15 @@ public class ModelApiResponse  {
 
   public static final String JSON_PROPERTY_CODE = "code";
 
-  private Integer code;
+  protected Integer code;
 
   public static final String JSON_PROPERTY_TYPE = "type";
 
-  private String type;
+  protected String type;
 
   public static final String JSON_PROPERTY_MESSAGE = "message";
 
-  private String message;
+  protected String message;
 
 
   /**

samples/client/petstore/java/microprofile-rest-client-3.0-jackson-mutiny/src/main/java/org/openapitools/client/model/Order.java

@@ -41,19 +41,19 @@ public class Order  {
 
   public static final String JSON_PROPERTY_ID = "id";
 
-  private Long id;
+  protected Long id;
 
   public static final String JSON_PROPERTY_PET_ID = "petId";
 
-  private Long petId;
+  protected Long petId;
 
   public static final String JSON_PROPERTY_QUANTITY = "quantity";
 
-  private Integer quantity;
+  protected Integer quantity;
 
   public static final String JSON_PROPERTY_SHIP_DATE = "shipDate";
 
-  private Date shipDate;
+  protected Date shipDate;
 
   public enum StatusEnum {
 
@@ -92,11 +92,11 @@ public static StatusEnum fromValue(String value) {
   * Order Status
   */
 
-  private StatusEnum status;
+  protected StatusEnum status;
 
   public static final String JSON_PROPERTY_COMPLETE = "complete";
 
-  private Boolean complete = false;
+  protected Boolean complete = false;
 
 
   /**

samples/client/petstore/java/microprofile-rest-client-3.0-jackson-mutiny/src/main/java/org/openapitools/client/model/Pet.java

@@ -45,23 +45,23 @@ public class Pet  {
 
   public static final String JSON_PROPERTY_ID = "id";
 
-  private Long id;
+  protected Long id;
 
   public static final String JSON_PROPERTY_CATEGORY = "category";
 
-  private Category category;
+  protected Category category;
 
   public static final String JSON_PROPERTY_NAME = "name";
 
-  private String name;
+  protected String name;
 
   public static final String JSON_PROPERTY_PHOTO_URLS = "photoUrls";
 
-  private List<String> photoUrls = new ArrayList<>();
+  protected List<String> photoUrls = new ArrayList<>();
 
   public static final String JSON_PROPERTY_TAGS = "tags";
 
-  private List<Tag> tags = null;
+  protected List<Tag> tags = null;
 
   public enum StatusEnum {
 
@@ -100,7 +100,7 @@ public static StatusEnum fromValue(String value) {
   * pet status in the store
   */
 
-  private StatusEnum status;
+  protected StatusEnum status;
 
 
   /**

samples/client/petstore/java/microprofile-rest-client-3.0-jackson-mutiny/src/main/java/org/openapitools/client/model/Tag.java

@@ -36,11 +36,11 @@ public class Tag  {
 
   public static final String JSON_PROPERTY_ID = "id";
 
-  private Long id;
+  protected Long id;
 
   public static final String JSON_PROPERTY_NAME = "name";
 
-  private String name;
+  protected String name;
 
 
   /**

samples/client/petstore/java/microprofile-rest-client-3.0-jackson-mutiny/src/main/java/org/openapitools/client/model/User.java

@@ -42,38 +42,38 @@ public class User  {
 
   public static final String JSON_PROPERTY_ID = "id";
 
-  private Long id;
+  protected Long id;
 
   public static final String JSON_PROPERTY_USERNAME = "username";
 
-  private String username;
+  protected String username;
 
   public static final String JSON_PROPERTY_FIRST_NAME = "firstName";
 
-  private String firstName;
+  protected String firstName;
 
   public static final String JSON_PROPERTY_LAST_NAME = "lastName";
 
-  private String lastName;
+  protected String lastName;
 
   public static final String JSON_PROPERTY_EMAIL = "email";
 
-  private String email;
+  protected String email;
 
   public static final String JSON_PROPERTY_PASSWORD = "password";
 
-  private String password;
+  protected String password;
 
   public static final String JSON_PROPERTY_PHONE = "phone";
 
-  private String phone;
+  protected String phone;
 
   public static final String JSON_PROPERTY_USER_STATUS = "userStatus";
  /**
   * User Status
   */
 
-  private Integer userStatus;
+  protected Integer userStatus;
 
 
   /**

samples/client/petstore/java/microprofile-rest-client-3.0-jackson-with-xml/src/main/java/org/openapitools/client/model/Category.java

@@ -47,11 +47,11 @@ public class Category  {
 
   public static final String JSON_PROPERTY_ID = "id";
   @XmlElement(name = "id")
-  private Long id;
+  protected Long id;
 
   public static final String JSON_PROPERTY_NAME = "name";
   @XmlElement(name = "name")
-  private String name;
+  protected String name;
 
 
   /**