Skip to content

Commit d86b3c1

Browse files
PicazsooCopilot
andcommitted
fix: remove literal quotes from ruby all_samples and restore nestjs node-version matrix
samples-ruby.yaml: all three all_samples entries were wrapped in single quotes ('samples/...'). YAML block scalars treat these as literal characters so compute-matrix prefix matching never matched — ruby builds silently skipped on every PR regardless of what changed. samples-typescript-nestjs-server.yaml: the original workflow had a 2D matrix (node-version x sample). The refactor accidentally placed node versions 20 and 22 into all_samples: and dropped the node-version static dimension, making matrix.node-version undefined at runtime. Restores node-version: [20, 22] as a static dimension alongside the samples output (same pattern as samples-swift5.yaml uses for os: + sample:). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 7e2dc7c commit d86b3c1

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

.github/workflows/samples-ruby.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ jobs:
3030
# Action inputs don't support arrays, so this is a newline-delimited string parsed in the action script.
3131
# To add a new sample: add it here AND add a matching entry to the paths: trigger above.
3232
all_samples: |
33-
'samples/client/echo_api/ruby-httpx/'
34-
'samples/client/echo_api/ruby-faraday/'
35-
'samples/client/echo_api/ruby-typhoeus/'
33+
samples/client/echo_api/ruby-httpx
34+
samples/client/echo_api/ruby-faraday
35+
samples/client/echo_api/ruby-typhoeus
3636
3737
build:
3838
name: Build Ruby

.github/workflows/samples-typescript-nestjs-server.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
setup:
1212
runs-on: ubuntu-latest
1313
outputs:
14-
matrix: ${{ steps.filter.outputs.matrix }}
14+
samples: ${{ steps.filter.outputs.samples }}
1515
steps:
1616
- uses: actions/checkout@v5
1717
with:
@@ -24,17 +24,17 @@ jobs:
2424
# To add a new sample: add it here AND add a matching entry to the paths: trigger above.
2525
all_samples: |
2626
samples/server/petstore/typescript-nestjs-server
27-
20
28-
22
2927
3028
build:
3129
name: Test TypeScript NestJS Server
3230
needs: setup
33-
if: ${{ needs.setup.outputs.matrix != '[]' }}
31+
if: ${{ needs.setup.outputs.samples != '[]' }}
3432
runs-on: ubuntu-latest
3533
strategy:
3634
fail-fast: false
37-
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
35+
matrix:
36+
node-version: [20, 22]
37+
sample: ${{ fromJson(needs.setup.outputs.samples) }}
3838
steps:
3939
- uses: actions/checkout@v5
4040

0 commit comments

Comments
 (0)