Skip to content

Commit dd89576

Browse files
committed
fix generated JsonTypeName when using underscore in schema names
1 parent af3dd8c commit dd89576

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JavaJAXRSSpecServerCodegen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ public Map<String, ModelsMap> postProcessAllModels(Map<String, ModelsMap> objs)
373373
CodegenDiscriminator discriminator = model.parentModel.getDiscriminator();
374374
if (discriminator != null) {
375375
for (CodegenDiscriminator.MappedModel mappedModel : discriminator.getMappedModels()) {
376-
if (mappedModel.getModelName().equals(model.name)) {
376+
if (mappedModel.getSchemaName().equals(model.schemaName)) {
377377
model.getVendorExtensions().put("x-discriminator-value", mappedModel.getMappingName());
378378
break;
379379
}

modules/openapi-generator/src/test/resources/3_0/jaxrs/petstore.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -771,20 +771,20 @@ components:
771771
type: string
772772
oneOf:
773773
- $ref: '#/components/schemas/CatRequest'
774-
- $ref: '#/components/schemas/DogRequest'
774+
- $ref: '#/components/schemas/Dog_Request'
775775
discriminator:
776776
propertyName: petType
777777
mapping:
778778
CAT: '#/components/schemas/CatRequest'
779-
DOG: '#/components/schemas/DogRequest'
779+
DOG: '#/components/schemas/Dog_Request'
780780
CatRequest:
781781
allOf:
782782
- $ref: '#/components/schemas/PetRequest'
783783
- type: object
784784
properties:
785785
indoor:
786786
type: boolean
787-
DogRequest:
787+
Dog_Request:
788788
allOf:
789789
- $ref: '#/components/schemas/PetRequest'
790790
- type: object

samples/server/petstore/jaxrs-cxf-cdi/src/gen/java/org/openapitools/model/DogRequest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.fasterxml.jackson.annotation.JsonProperty;
44
import com.fasterxml.jackson.annotation.JsonCreator;
5+
import com.fasterxml.jackson.annotation.JsonTypeName;
56
import io.swagger.annotations.ApiModel;
67
import io.swagger.annotations.ApiModelProperty;
78
import org.openapitools.model.PetRequest;

0 commit comments

Comments
 (0)