[BUG][Java] Required fields not honored in @JsonProperty annotations

[elagerho]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?

Description

The Pojo and Jackson annotation templates are not honoring required fields in the spec. Adjacent @JsonBProperty annotations do.

Expected annotations with required fields:

@JsonProperty(value = JSON_PROPERTY_NAME, required = true)

Actual annotations

@JsonProperty(JSON_PROPERTY_NAME)

openapi-generator version

master

OpenAPI declaration file content or url

openapi: 3.0.0
info:
  title: 'Some API'
  version: 1.0.0
servers:
  - url: 'https://localhost'
paths:
  /v1/some_path:
    get:
      responses:
        '200':
          content:
            application/json:
              schema:
                type: object
                properties:
                  foo:
                    type: string
                required:
                  - foo
          description: "some description"

Steps to reproduce

1. Have a spec with any required field
2. Run the Java codegen with Jackson serialization
3. See the generated model is not honoring required in the @JsonProperty annotation

Related issues/PRs

Have searched but not found any.

Suggest a fix

I will submit a PR with changes for further consideration.

[Laar]

What should this do if the property is marked as readOnly (server) or writeOnly (client)? As JsonProperty#required seems to only be applied on deserialization. So setting it on those properties would do nothing but may confuse people.

[elagerho]

What should this do if the property is marked as readOnly (server) or writeOnly (client)? As JsonProperty#required seems to only be applied on deserialization. So setting it on those properties would do nothing but may confuse people.

Thanks for your input @Laar What would be the confusion do you think if you have a required field that is also readOnly or writeOnly? Trying to understand in detail what you mean.

[Binnette]

Hi @wing328, TY for merging #21062 from @elagerho.

But I do not see this bug (#21060) in the release note of version v7.16.0.

Is this bugfix embedded is this release? If yes, can you please add #21060 in the release note and close this issue?

Thanks a lot and have a nice day 👍