[kotlin] implement serializable data classes (fix #8317)#18386
Conversation
|
cc |
|
Could someone please review this? |
|
Hi, can you please take a look at CI that is failing? and another one |
|
@4brunu Thanks for checking, and sorry for the late reaction. I fixed the issue with uncommitted changes in the samples files, but I'm not sure about the second problem you pointed out. Where do you see this, or how could I try to reproduce this problem? |
|
CI is failing, here is the link. |
|
@4brunu Seems the issue has been fixed by someone else on the master branch, the CI no longer fails. |
Implement
java.io.Serializablein kotlin data classes forkotlin-springgenerator whenserializableModeloption is enabled.Fixes #8317.
These existing samples clearly show the effect of this change, as they have
serializableModelalready set to true:See the added
Serializableinterface on all generated models for those samples, as well as theserialVersionUIDconstant in each data class.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)