Refactoring: Use lombok for simple getters & setters#18559
Merged
Conversation
02ed275 to
bad99fe
Compare
bad99fe to
1a26907
Compare
Contributor
Author
|
@wing328 This PR was lying dormant for over two weeks as it appears the automatically assigned reviewer is unavailable. I've now rebased everything on Would love this to go in first so i can rebase my other open PRs on it (as it greatly simplfies things with ~3500 LOC saved). |
Member
|
thanks for the PR. overall it looks good as it simplifies the code. can you please resolve the merge conflicts when you've time? we can definitely give it a try. |
1a26907 to
ac1152f
Compare
Contributor
Author
@wing328 Done! |
87dd1ba to
384ed27
Compare
384ed27 to
0be78bf
Compare
Contributor
Author
|
Just re-rebased this mother of all PRs… kindly merge at your earliest convenience :) |
welshm
pushed a commit
to welshm/openapi-generator
that referenced
this pull request
Jun 5, 2024
) * Add missing @OverRide annotation * Fix JavaDoc unresolved symbol * Fix JavaDoc method link * Remove unnecessary semicolon * Remove method identical to super implementations * Replace repetitive getter code with Lombok @Getter See https://projectlombok.org/features/GetterSetter * Replace repetitive setter code with Lombok @Setter See https://projectlombok.org/features/GetterSetter * Generate no-args constructor with Lombok * Generate all-args constructor with Lombok * Fix parameter naming * Replace stubbed abstract class implementations with Mockito mocks * Remove unused import(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Lombok is available throughout the project and also used in a couple of places, we can use it to remove several thousand lines of boilerplate code. This PR applies mostly
@Getterand@Setterannotations wherever feasible, while not replacing any getter or setter methods that already have annotations (which could be facilitated via theonXmeta-annotation, however for now refraining from using it as it is still experimental).This makes the code base and – most importantly – the cognitive complexity to work through the repo considerably smaller. Also the declarative approach has the advantage that one can see immediately if a field is exposed in the public API by just looking at the declaration annotation.
This PR also contains some Javadoc and
@Overrideannotation fixes and removes identical implementations in inherited classes.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)