[Java][native] Fix: useEnumCaseInsensitive option fixed in Java Native Model Enum#18762
Merged
wing328 merged 1 commit intoJun 17, 2024
Merged
Conversation
Member
|
tested locally to confirm the fix --- a/src/main/java/org/openapitools/client/model/EnumTest.java
+++ b/src/main/java/org/openapitools/client/model/EnumTest.java
@@ -55,7 +55,7 @@ public enum EnumTest {
@JsonCreator
public static EnumTest fromValue(String value) {
for (EnumTest b : EnumTest.values()) {
- if (b.value.equals(value)) {
+ if (b.value.equalsIgnoreCase(value)) {
return b;
}
}
thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useEnumCaseInsensitiveoption does not work in Java Enum Classes for native library. It is implemented implemented in the default template but not in the native template. This PR copies the conditionalequalsIgnoreCasecall from default template tonative.Seems like this change was forgotten in this PR: #15273
More details are shared in this issue: #18761
Java Committee Members:
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)