[BUG][Csharp][GenericHost] OpenApi 3.1: Model property of type map/additionalproperties gets generated as object#18772
Merged
wing328 merged 3 commits intoJun 2, 2024
Conversation
wing328
reviewed
May 28, 2024
| @@ -0,0 +1,14 @@ | |||
| # for csharp generichost | |||
| generatorName: csharp | |||
| outputDir: samples/client/petstore/csharp/generichost/net8/OneOfDiscriminator-3.1.0 | |||
Member
There was a problem hiding this comment.
thanks for the PR, which looks good me.
after merging, i'll replace this test (sample) with a unit test instead similar to other 3.1 tests we've added so far.
welshm
pushed a commit
to welshm/openapi-generator
that referenced
this pull request
Jun 5, 2024
…ditionalproperties gets generated as object (OpenAPITools#18772) * Fix the bug + add test case * Add sample output * Update version number in new sample output --------- Co-authored-by: Gerwin Jansen <gerwinjansen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #17624 introduced an issue when generating code for a model with a property of type map/additionalproperties
PR checklist
Input
Expected output
Actual output