Skip to content

[php-laravel] Fix file database/migrations/2019_08_19_000000 being written twice#18832

Merged
Philzen merged 5 commits into
OpenAPITools:masterfrom
Philzen:bugfix/18831-php-laravel-generates-a-file-twice
Jun 5, 2024
Merged

[php-laravel] Fix file database/migrations/2019_08_19_000000 being written twice#18832
Philzen merged 5 commits into
OpenAPITools:masterfrom
Philzen:bugfix/18831-php-laravel-generates-a-file-twice

Conversation

@Philzen
Copy link
Copy Markdown
Contributor

@Philzen Philzen commented Jun 2, 2024

Resolves #18831

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Philzen Philzen force-pushed the bugfix/18831-php-laravel-generates-a-file-twice branch from 95d5931 to e9a2b83 Compare June 4, 2024 14:37
@Philzen Philzen marked this pull request as ready for review June 4, 2024 14:38
@Philzen Philzen force-pushed the bugfix/18831-php-laravel-generates-a-file-twice branch from e9a2b83 to 082fc47 Compare June 4, 2024 15:02
@Philzen Philzen merged commit 45bc9c9 into OpenAPITools:master Jun 5, 2024
welshm pushed a commit to welshm/openapi-generator that referenced this pull request Jun 5, 2024
…itten twice (OpenAPITools#18832)

* Implement dedicated transitional test for OpenAPITools#18831 bugfix

* Remove duplicated database migration file from supportingFiles collection

* Activate AllGeneratorsTest.noDuplicateSupportingFiles

* Drop transitional test again

* Simplify truthy assertions
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [php-laravel] Writes file database/migrations/2019_08_19_000000 twice

2 participants