Skip to content

Remove unused retrofit v1 mustache templates#18833

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
Philzen:change/remove-unused-retrofit1-mustache-files
Jun 4, 2024
Merged

Remove unused retrofit v1 mustache templates#18833
wing328 merged 1 commit into
OpenAPITools:masterfrom
Philzen:change/remove-unused-retrofit1-mustache-files

Conversation

@Philzen
Copy link
Copy Markdown
Contributor

@Philzen Philzen commented Jun 2, 2024

These are not used by any generator implementation, hence there's no point in bundling them into every release we're shipping.

In case someday it is decided that a retrofit v1 generator will be needed again, this commit can simply be reverted.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

These are not used by any generator implementation, hence there's no
point in bundling them into every release we're shipping.

In case someday it is decided that a retrofit v1 generator will be needed
again, this commit can simply be reverted.
@Philzen Philzen changed the title Remove unused retrofit1 mustache templates Remove unused retrofit v1 mustache templates Jun 2, 2024
@Philzen Philzen marked this pull request as ready for review June 2, 2024 18:08
@wing328 wing328 merged commit a574d9e into OpenAPITools:master Jun 4, 2024
welshm pushed a commit to welshm/openapi-generator that referenced this pull request Jun 5, 2024
These are not used by any generator implementation, hence there's no
point in bundling them into every release we're shipping.

In case someday it is decided that a retrofit v1 generator will be needed
again, this commit can simply be reverted.
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants