Make it easier to specify triggers for Zapier#19638
Closed
wing328 wants to merge 7 commits into
Closed
Conversation
…are/openapi-generator into MarketplaceSoftware-zapier_triggers23
5 tasks
wing328
changed the title
wing328
changed the title
wing328
commented
Sep 22, 2024
| const { triggerMiddleware, isTrigger, searchMiddleware, hasSearchRequisites, isSearchAction } = require('../utils/utils'); | ||
|
|
||
| const actions = { | ||
| const operations = { |
Member
Author
There was a problem hiding this comment.
@a-wallen is this a breaking change? shall we keep the const name as actions?
Contributor
There was a problem hiding this comment.
We can keep the name. Also we need to drop the commit that says (EM Only)
Contributor
Contributor
There was a problem hiding this comment.
Looks like I was also able to update the samples properly by using the devcontainer in 86307de!
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #18814 with updated samples
cc @valmoz, @emajo
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)