OpenAPI Generator - Online - Upgrade spring boot to 3.5#22370
Open
shub-est wants to merge 4 commits intoOpenAPITools:masterfrom
Open
OpenAPI Generator - Online - Upgrade spring boot to 3.5#22370shub-est wants to merge 4 commits intoOpenAPITools:masterfrom
shub-est wants to merge 4 commits intoOpenAPITools:masterfrom
Conversation
Signed-off-by: Shubham Kalloli <shubham.kalloli@est.tech>
Signed-off-by: Shubham Kalloli <shubham.kalloli@est.tech>
Signed-off-by: Shubham Kalloli <shubham.kalloli@est.tech>
Author
|
Hi @wing328, I have reviewed the build failures and I can see that the workflows are still using Java 11 to build the online module. The main OpenAPI Generator Build workflow uses Java 11 as well. In order to overcome this, we could do the following:
What are your thoughts on the approach that we should adopt here? |
Member
|
we can wait for the upcoming major release v8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded Online module to use Java 17 and Spring Boot 3.5
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)