When using the jsonb parameter, a bug occurred in the java-helidon-client#22488
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Dec 17, 2025
Merged
When using the jsonb parameter, a bug occurred in the java-helidon-client#22488wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
…the problems caused by the changes in v4 style.
Member
|
thanks for the PR cc @tjquinno for review |
Member
|
let's give it a try thanks for the contribution |
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…the problems caused by the changes in v4 style. (OpenAPITools#22488) Co-authored-by: rainmenzhao <43979071+rainmenzhao@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22487
After inspection, it was found that, apart from spelling errors, jsob did not handle the style changes introduced in helidon v4 as jackson did.
1.Correct the spelling errors and handle the jsonb data in the same way as described by jackson.
io.helidon.http.media
helidon-http1media-jsonb
io.helidon.{{^x-helidon-v3}}http.{{/x-helidon-v3}}media
helidon-{{^x-helidon-v3}}http-{{/x-helidon-v3}}jsonb
2.Refer to the "jackson" method to perform corresponding processing on other referenced jsonb data.
Currently, Helidon officially supports three versions: V2, V3, and V4. After analysis, the current way of Jackson handling the changes in V4 style has some flaws. When using the V2 version, there are bugs and not all affected areas have been properly addressed. Due to the heavy workload, we will first make corrections using the original method, and then allocate more time for optimization later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)