[KOTLIN][CLIENT] Fix: Store parsed bool values in additionalProperties#22491
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 7, 2025
Merged
[KOTLIN][CLIENT] Fix: Store parsed bool values in additionalProperties#22491wing328 merged 1 commit intoOpenAPITools:masterfrom
additionalProperties#22491wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
e45c049 to
f1d8ce0
Compare
f1d8ce0 to
3832587
Compare
Contributor
Author
|
The CI is failing for some reason, but it seems to be unrelated to the changes made in this PR. Running the tests locally returns success: [WARNING] Tests run: 3594, Failures: 0, Errors: 0, Skipped: 4 |
Member
|
ci failure not related to this pr thanks for the contribution. |
lucy66hw
pushed a commit
to lucy66hw/openapi-generator
that referenced
this pull request
Dec 16, 2025
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contents of
Map<String, Object> additionalPropertiesare passed to the templates, but when these options are set via command-line thisMapisn't updated.For instance in
Serializer.mustache.kt:105the block will be incorrectly included in the output file even when--additional-properties=generateOneOfAnyOfWrappers=falsewas set on the command-line.@jimschubert
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)