Fix: Gradle plugin tests failing with Java 23#23208
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Mar 12, 2026
Merged
Fix: Gradle plugin tests failing with Java 23#23208wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
…ility Made-with: Cursor
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Member
|
lgtm. thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Gradle plugin tests failing with Java 23
While building the project, the module
openapi-generator-gradle-pluginfailed with 26 test failures when running tests parameterized with
Gradle 8.5.
Error observed:
BUG! exception in phase 'semantic analysis' in source unit 'BuildScript'
Unsupported class file major version 67
Root cause:
The tests were executed on Java 23. Gradle 8.5 does not support
running on Java 23, which causes Groovy compilation failures.
According to the Gradle compatibility matrix, Java 23 support
starts with Gradle 8.10.
Solution:
Update the Gradle version used in the test parameter providers
from 8.5 to 8.10 in the following files:
After the change all tests pass successfully.
Summary by cubic
Updated Gradle versions used in
openapi-generator-gradle-plugintests to 8.10 to fix failures on Java 23. Prevents Groovy compile errors seen with Gradle 8.5.Written for commit 1d7a995. Summary will update on new commits.