Tests with the latest gradle version 8.14.4 only as only this works with JDK25#23216
Merged
Tests with the latest gradle version 8.14.4 only as only this works with JDK25#23216
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskFromCacheTest.kt">
<violation number="1" location="modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskFromCacheTest.kt:25">
P3: The data provider contains a duplicated `8.14.4` entry, causing redundant test runs with no additional coverage.</violation>
</file>
<file name="modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskConfigurationCacheTest.kt">
<violation number="1" location="modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskConfigurationCacheTest.kt:23">
P3: The data provider includes the same Gradle version twice, causing duplicate identical test runs and redundant CI time.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| @DataProvider(name = "gradle_version_provider") | ||
| private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.10")) | ||
| private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4")) |
Contributor
There was a problem hiding this comment.
P3: The data provider contains a duplicated 8.14.4 entry, causing redundant test runs with no additional coverage.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskFromCacheTest.kt, line 25:
<comment>The data provider contains a duplicated `8.14.4` entry, causing redundant test runs with no additional coverage.</comment>
<file context>
@@ -22,7 +22,7 @@ class GenerateTaskFromCacheTest : TestBase() {
@DataProvider(name = "gradle_version_provider")
- private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.10"))
+ private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4"))
// inputSpec tests
</file context>
Suggested change
| private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4")) | |
| private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4")) |
|
|
||
| @DataProvider(name = "gradle_version_provider") | ||
| private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.10")) | ||
| private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4")) |
Contributor
There was a problem hiding this comment.
P3: The data provider includes the same Gradle version twice, causing duplicate identical test runs and redundant CI time.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskConfigurationCacheTest.kt, line 23:
<comment>The data provider includes the same Gradle version twice, causing duplicate identical test runs and redundant CI time.</comment>
<file context>
@@ -20,7 +20,7 @@ class GenerateTaskConfigurationCacheTest : TestBase() {
@DataProvider(name = "gradle_version_provider")
- private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.10"))
+ private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4"))
@DataProvider(name = "gradle_version_provider_without_cc")
</file context>
Suggested change
| private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4")) | |
| private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4")) |
Member
Author
There was a problem hiding this comment.
expected. we will update it later when 8.14.5 releases
Contributor
There was a problem hiding this comment.
Understood, thanks for the context—will treat this as intentional until 8.14.5 is out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests with the latest gradle version 8.14.4 only as only this works with JDK25 (./mvnw clean install -DskipTests)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Replace Gradle 8.10 with 8.14.4 in Gradle plugin tests so they run on JDK 25 and keep CI green.
GenerateTaskConfigurationCacheTest,GenerateTaskFromCacheTest, andGenerateTaskUpToDateTestto use 8.14.4 for all parameterized runs.ValidateTaskDslTestexplicit version from 8.10 to 8.14.4 (keepsnullto use the plugin’s build Gradle).GenerateTaskConfigurationCacheTestat 5.6.1.Written for commit 74a1dcc. Summary will update on new commits.