Skip to content

Tests with the latest gradle version 8.14.4 only as only this works with JDK25#23216

Merged
wing328 merged 2 commits intomasterfrom
fix-jdk25-build-issue
Mar 12, 2026
Merged

Tests with the latest gradle version 8.14.4 only as only this works with JDK25#23216
wing328 merged 2 commits intomasterfrom
fix-jdk25-build-issue

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Mar 12, 2026

Tests with the latest gradle version 8.14.4 only as only this works with JDK25 (./mvnw clean install -DskipTests)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Replace Gradle 8.10 with 8.14.4 in Gradle plugin tests so they run on JDK 25 and keep CI green.

  • Dependencies
    • Updated Gradle version providers in GenerateTaskConfigurationCacheTest, GenerateTaskFromCacheTest, and GenerateTaskUpToDateTest to use 8.14.4 for all parameterized runs.
    • Switched ValidateTaskDslTest explicit version from 8.10 to 8.14.4 (keeps null to use the plugin’s build Gradle).
    • Kept the no-configuration-cache provider in GenerateTaskConfigurationCacheTest at 5.6.1.

Written for commit 74a1dcc. Summary will update on new commits.

@wing328 wing328 added this to the 7.21.0 milestone Mar 12, 2026
@wing328 wing328 marked this pull request as ready for review March 12, 2026 08:44
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskFromCacheTest.kt">

<violation number="1" location="modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskFromCacheTest.kt:25">
P3: The data provider contains a duplicated `8.14.4` entry, causing redundant test runs with no additional coverage.</violation>
</file>

<file name="modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskConfigurationCacheTest.kt">

<violation number="1" location="modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskConfigurationCacheTest.kt:23">
P3: The data provider includes the same Gradle version twice, causing duplicate identical test runs and redundant CI time.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.


@DataProvider(name = "gradle_version_provider")
private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.10"))
private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4"))
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The data provider contains a duplicated 8.14.4 entry, causing redundant test runs with no additional coverage.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskFromCacheTest.kt, line 25:

<comment>The data provider contains a duplicated `8.14.4` entry, causing redundant test runs with no additional coverage.</comment>

<file context>
@@ -22,7 +22,7 @@ class GenerateTaskFromCacheTest : TestBase() {
 
     @DataProvider(name = "gradle_version_provider")
-    private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.10"))
+    private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4"))
 
     // inputSpec tests
</file context>
Suggested change
private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4"))
private fun gradleVersionProvider(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"))
Fix with Cubic


@DataProvider(name = "gradle_version_provider")
private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.10"))
private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4"))
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The data provider includes the same Gradle version twice, causing duplicate identical test runs and redundant CI time.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskConfigurationCacheTest.kt, line 23:

<comment>The data provider includes the same Gradle version twice, causing duplicate identical test runs and redundant CI time.</comment>

<file context>
@@ -20,7 +20,7 @@ class GenerateTaskConfigurationCacheTest : TestBase() {
 
     @DataProvider(name = "gradle_version_provider")
-    private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.10"))
+    private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4"))
 
     @DataProvider(name = "gradle_version_provider_without_cc")
</file context>
Suggested change
private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"), arrayOf("8.14.4"))
private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.14.4"))
Fix with Cubic

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected. we will update it later when 8.14.5 releases

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thanks for the context—will treat this as intentional until 8.14.5 is out.

@wing328 wing328 merged commit e0df52a into master Mar 12, 2026
17 checks passed
@wing328 wing328 deleted the fix-jdk25-build-issue branch March 12, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant