[Java] [Spring] Remove findBugs if useJspecify=true

[jpfinne]

remove findbug dependency in java/Spring generators when jspecify is used.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) ) @lwlee2608 (2019/10)

---

Summary by cubic

Removes com.google.code.findbugs:jsr305 when useJspecify=true to prevent duplicate nullability annotations and keep builds lean. Expands tests for Java and Spring generators across Spring Boot 2/3/4 to verify jsr305 is excluded and SB4 templates avoid both jspecify and findbugs.

• Dependencies
  • Wrap jsr305 with {{^useJspecify}} in Java and JavaSpring templates for Maven/Gradle (native, resttemplate, webclient, spring-boot, spring-cloud, spring-http-interface).
  • Remove jsr305 from JSpecify sample projects to match the new behavior.

^{Written for commit 703b398. Summary will update on new commits.}

[jpfinne]

Superseed #23397 by @antechrestos

[cubic-dev-ai]

2 issues found across 23 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java">

<violation number="1" location="modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java:6628">
P2: Parameterized `testJspecify` no longer exercises the Spring Boot 2 combination, dropping coverage of the Boot2 pom/template path.</violation>
</file>

<file name="modules/openapi-generator/src/main/resources/JavaSpring/libraries/spring-cloud/pom-sb4.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/JavaSpring/libraries/spring-cloud/pom-sb4.mustache:87">
P2: pom-sb4.mustache removes jsr305 when useJspecify=true but never adds the jspecify dependency, unlike other Spring Cloud templates. This can leave generated projects missing the annotation library when jspecify annotations are emitted.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: pom-sb4.mustache removes jsr305 when useJspecify=true but never adds the jspecify dependency, unlike other Spring Cloud templates. This can leave generated projects missing the annotation library when jspecify annotations are emitted.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/JavaSpring/libraries/spring-cloud/pom-sb4.mustache, line 87:

<comment>pom-sb4.mustache removes jsr305 when useJspecify=true but never adds the jspecify dependency, unlike other Spring Cloud templates. This can leave generated projects missing the annotation library when jspecify annotations are emitted.</comment>

<file context>
@@ -84,6 +84,7 @@
         </dependency>
         {{/swagger2AnnotationLibrary}}
         {{/springDocDocumentationProvider}}
+        {{^useJspecify}}
         <!-- @Nullable annotation -->
         <dependency>
</file context>