Skip to content

[GRADLE-WRAPPER] feat: add configurable worker isolation and max heap size for code generation#23648

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
Picazsoo:feature/configurable-worker-isolation-in-gradle-mvn-wrapper
Apr 29, 2026
Merged

[GRADLE-WRAPPER] feat: add configurable worker isolation and max heap size for code generation#23648
wing328 merged 2 commits intoOpenAPITools:masterfrom
Picazsoo:feature/configurable-worker-isolation-in-gradle-mvn-wrapper

Conversation

@Picazsoo
Copy link
Copy Markdown
Contributor

@Picazsoo Picazsoo commented Apr 28, 2026

In my spring boot project I have about 20 generation tasks in my gradle build. So during building in memory-constrained environments, I run out of metaspace very quickly. This feature allows one to manually decide between possible latency introduced by spinning up separate jvm for each generation task vs reusing one process with separated class loaders (with increased pressure on metaspace requirements)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds configurable worker isolation and optional max heap for Gradle code generation tasks. Default stays classloader; switch to process to avoid Gradle daemon Metaspace pressure.

  • New Features

    • workerIsolation: classloader (default) or process.
    • maxWorkerHeapSize: sets heap for the forked worker JVM when using process (e.g. "1g").
    • Updated task wiring, README, and logs to explain trade-offs.
  • Migration

    • No changes required.
    • For CI or many generation tasks, set workerIsolation = "process" and optionally maxWorkerHeapSize.

Written for commit e21f51f. Summary will update on new commits. Review in cubic

@Picazsoo Picazsoo marked this pull request as ready for review April 28, 2026 22:37
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator-gradle-plugin/src/main/kotlin/org/openapitools/generator/gradle/plugin/tasks/GenerateTask.kt">

<violation number="1" location="modules/openapi-generator-gradle-plugin/src/main/kotlin/org/openapitools/generator/gradle/plugin/tasks/GenerateTask.kt:910">
P2: Invalid `workerIsolation` values are silently coerced to process isolation instead of being rejected.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@wing328 wing328 added this to the 7.23.0 milestone Apr 29, 2026
@wing328 wing328 merged commit 9faa37f into OpenAPITools:master Apr 29, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants