[GRADLE-WRAPPER] feat: add configurable worker isolation and max heap size for code generation#23648
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Apr 29, 2026
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator-gradle-plugin/src/main/kotlin/org/openapitools/generator/gradle/plugin/tasks/GenerateTask.kt">
<violation number="1" location="modules/openapi-generator-gradle-plugin/src/main/kotlin/org/openapitools/generator/gradle/plugin/tasks/GenerateTask.kt:910">
P2: Invalid `workerIsolation` values are silently coerced to process isolation instead of being rejected.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my spring boot project I have about 20 generation tasks in my gradle build. So during building in memory-constrained environments, I run out of metaspace very quickly. This feature allows one to manually decide between possible latency introduced by spinning up separate jvm for each generation task vs reusing one process with separated class loaders (with increased pressure on metaspace requirements)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds configurable worker isolation and optional max heap for Gradle code generation tasks. Default stays
classloader; switch toprocessto avoid Gradle daemon Metaspace pressure.New Features
workerIsolation:classloader(default) orprocess.maxWorkerHeapSize: sets heap for the forked worker JVM when usingprocess(e.g."1g").Migration
workerIsolation = "process"and optionallymaxWorkerHeapSize.Written for commit e21f51f. Summary will update on new commits. Review in cubic