Skip to content

[BUG][JAVA][Spring] 23681 - Add JSpecify @Nullable to fluent setter parameter for optional properties#23683

Draft
Quin-Proctor-GGL wants to merge 1 commit intoOpenAPITools:masterfrom
Quin-Proctor-GGL:QuinProctor/fix-jspecify-nullable-23681
Draft

[BUG][JAVA][Spring] 23681 - Add JSpecify @Nullable to fluent setter parameter for optional properties#23683
Quin-Proctor-GGL wants to merge 1 commit intoOpenAPITools:masterfrom
Quin-Proctor-GGL:QuinProctor/fix-jspecify-nullable-23681

Conversation

@Quin-Proctor-GGL
Copy link
Copy Markdown

@Quin-Proctor-GGL Quin-Proctor-GGL commented May 4, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add JSpecify @Nullable to fluent setter parameters for optional properties in the JavaSpring generator. This fixes missing nullability on setter parameters and aligns with generated field annotations.

  • Bug Fixes
    • In JavaSpring/pojo.mustache, changed setter param from {{{datatypeWithEnum}}} to {{>nullableDataType}} while keeping {{>nullableAnnotation}}, so optional and container types carry correct JSpecify nullability.

Written for commit ac01da3. Summary will update on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant