feat(java/jersey3): support Spring Boot 4#23686
Open
MatteoMolinari93 wants to merge 1 commit intoOpenAPITools:masterfrom
Open
feat(java/jersey3): support Spring Boot 4#23686MatteoMolinari93 wants to merge 1 commit intoOpenAPITools:masterfrom
MatteoMolinari93 wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Wire the existing useSpringBoot4 client option into the jersey3 library templates so generated projects align with the Spring Boot 4.x baseline: - Java 17 compiler/source/target (was 1.8) - jakarta.annotation 3.0.0 (was 2.1.1) - jakarta.validation 3.1.1 (was 3.0.2) Defaults are unchanged when useSpringBoot4 is not set.
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/Java/libraries/jersey3/build.gradle.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/Java/libraries/jersey3/build.gradle.mustache:37">
P1: `useSpringBoot4` forces Java 17 in the Android build path, but this template still uses an old AGP/Gradle toolchain that does not support it.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Comment on lines
+37
to
+38
| sourceCompatibility JavaVersion.VERSION_17 | ||
| targetCompatibility JavaVersion.VERSION_17 |
Contributor
There was a problem hiding this comment.
P1: useSpringBoot4 forces Java 17 in the Android build path, but this template still uses an old AGP/Gradle toolchain that does not support it.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/Java/libraries/jersey3/build.gradle.mustache, line 37:
<comment>`useSpringBoot4` forces Java 17 in the Android build path, but this template still uses an old AGP/Gradle toolchain that does not support it.</comment>
<file context>
@@ -33,8 +33,14 @@ if(hasProperty('target') && target == 'android') {
}
compileOptions {
+ {{#useSpringBoot4}}
+ sourceCompatibility JavaVersion.VERSION_17
+ targetCompatibility JavaVersion.VERSION_17
+ {{/useSpringBoot4}}
</file context>
Suggested change
| sourceCompatibility JavaVersion.VERSION_17 | |
| targetCompatibility JavaVersion.VERSION_17 | |
| sourceCompatibility JavaVersion.VERSION_1_8 | |
| targetCompatibility JavaVersion.VERSION_1_8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the existing useSpringBoot4 client option into the jersey3 library templates so generated projects align with the Spring Boot 4.x baseline:
Defaults are unchanged when useSpringBoot4 is not set.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds Spring Boot 4 support to Java
jersey3clients behind theuseSpringBoot4=trueoption. When enabled, generated projects compile with Java 17 and usejakarta.annotation3.0.0 andjakarta.validation3.1.1; defaults are unchanged.useSpringBoot4intojersey3Gradle and Maven templates to set Java 17 and dependency versions.supportedLibrarieshelp text to document the flag.Written for commit 7d27873. Summary will update on new commits.