Skip to content

feat(java/jersey3): support Spring Boot 4#23686

Open
MatteoMolinari93 wants to merge 1 commit intoOpenAPITools:masterfrom
MatteoMolinari93:claude/jersey3-spring-boot-4-C2fti
Open

feat(java/jersey3): support Spring Boot 4#23686
MatteoMolinari93 wants to merge 1 commit intoOpenAPITools:masterfrom
MatteoMolinari93:claude/jersey3-spring-boot-4-C2fti

Conversation

@MatteoMolinari93
Copy link
Copy Markdown
Contributor

@MatteoMolinari93 MatteoMolinari93 commented May 4, 2026

Wire the existing useSpringBoot4 client option into the jersey3 library templates so generated projects align with the Spring Boot 4.x baseline:

  • Java 17 compiler/source/target (was 1.8)
  • jakarta.annotation 3.0.0 (was 2.1.1)
  • jakarta.validation 3.1.1 (was 3.0.2)

Defaults are unchanged when useSpringBoot4 is not set.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds Spring Boot 4 support to Java jersey3 clients behind the useSpringBoot4=true option. When enabled, generated projects compile with Java 17 and use jakarta.annotation 3.0.0 and jakarta.validation 3.1.1; defaults are unchanged.

  • New Features
    • Wire useSpringBoot4 into jersey3 Gradle and Maven templates to set Java 17 and dependency versions.
    • Update supportedLibraries help text to document the flag.

Written for commit 7d27873. Summary will update on new commits.

Wire the existing useSpringBoot4 client option into the jersey3 library
templates so generated projects align with the Spring Boot 4.x baseline:

- Java 17 compiler/source/target (was 1.8)
- jakarta.annotation 3.0.0 (was 2.1.1)
- jakarta.validation 3.1.1 (was 3.0.2)

Defaults are unchanged when useSpringBoot4 is not set.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/resources/Java/libraries/jersey3/build.gradle.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/Java/libraries/jersey3/build.gradle.mustache:37">
P1: `useSpringBoot4` forces Java 17 in the Android build path, but this template still uses an old AGP/Gradle toolchain that does not support it.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment on lines +37 to +38
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: useSpringBoot4 forces Java 17 in the Android build path, but this template still uses an old AGP/Gradle toolchain that does not support it.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/Java/libraries/jersey3/build.gradle.mustache, line 37:

<comment>`useSpringBoot4` forces Java 17 in the Android build path, but this template still uses an old AGP/Gradle toolchain that does not support it.</comment>

<file context>
@@ -33,8 +33,14 @@ if(hasProperty('target') && target == 'android') {
         }
         compileOptions {
+            {{#useSpringBoot4}}
+            sourceCompatibility JavaVersion.VERSION_17
+            targetCompatibility JavaVersion.VERSION_17
+            {{/useSpringBoot4}}
</file context>
Suggested change
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants