feat(jaxrs-jersey): add jersey3-spring-boot4 library for Spring Boot …#23687
Closed
MatteoMolinari93 wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
feat(jaxrs-jersey): add jersey3-spring-boot4 library for Spring Boot …#23687MatteoMolinari93 wants to merge 1 commit intoOpenAPITools:masterfrom
MatteoMolinari93 wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
…4 support Adds a new `jersey3-spring-boot4` library option to the `jaxrs-jersey` generator that produces a standalone JAR deployable with Spring Boot 4 (Spring Framework 7 + Jakarta EE 11) instead of a WAR artifact. Key changes: - New library constant `LIBRARY_JERSEY3_SPRING_BOOT4` registered alongside jersey2/jersey3 - `processOpts()` conditionally generates Spring Boot files instead of web.xml/Bootstrap.java - New Mustache templates in `JavaJaxRS/libraries/jersey3-spring-boot4/`: - `pom.mustache`: JAR packaging with `spring-boot-starter-jersey` parent BOM (Spring Boot 4.0.1, Java 17+) - `SpringBootApplication.mustache`: `@SpringBootApplication` main class with explicit `@ComponentScan` - `JerseyConfig.mustache`: `ResourceConfig` `@Component` that registers all JAX-RS resources via package scan - `application.mustache`: `application.properties` with server port and Jersey application path - `ApiOriginFilter.mustache`: servlet `Filter` annotated with `@Component` for Spring Boot auto-registration - `README.mustache`: usage instructions for Spring Boot deployment https://claude.ai/code/session_01T46fG2CEPhy2u1dmcXdEAH
Contributor
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/JavaJaxRS/libraries/jersey3-spring-boot4/JerseyConfig.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/JavaJaxRS/libraries/jersey3-spring-boot4/JerseyConfig.mustache:13">
P1: Unconditionally registering MultiPartFeature introduces a missing hard dependency on jersey-media-multipart in the generated Spring Boot 4 Jersey project.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| public JerseyConfig() { | ||
| packages("{{apiPackage}}"); | ||
| register(MultiPartFeature.class); |
Contributor
There was a problem hiding this comment.
P1: Unconditionally registering MultiPartFeature introduces a missing hard dependency on jersey-media-multipart in the generated Spring Boot 4 Jersey project.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/JavaJaxRS/libraries/jersey3-spring-boot4/JerseyConfig.mustache, line 13:
<comment>Unconditionally registering MultiPartFeature introduces a missing hard dependency on jersey-media-multipart in the generated Spring Boot 4 Jersey project.</comment>
<file context>
@@ -0,0 +1,15 @@
+
+ public JerseyConfig() {
+ packages("{{apiPackage}}");
+ register(MultiPartFeature.class);
+ }
+}
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…4 support
Adds a new
jersey3-spring-boot4library option to thejaxrs-jerseygenerator that produces a standalone JAR deployable with Spring Boot 4 (Spring Framework 7 + Jakarta EE 11) instead of a WAR artifact.Key changes:
LIBRARY_JERSEY3_SPRING_BOOT4registered alongside jersey2/jersey3processOpts()conditionally generates Spring Boot files instead of web.xml/Bootstrap.javaJavaJaxRS/libraries/jersey3-spring-boot4/:pom.mustache: JAR packaging withspring-boot-starter-jerseyparent BOM (Spring Boot 4.0.1, Java 17+)SpringBootApplication.mustache:@SpringBootApplicationmain class with explicit@ComponentScanJerseyConfig.mustache:ResourceConfig@Componentthat registers all JAX-RS resources via package scanapplication.mustache:application.propertieswith server port and Jersey application pathApiOriginFilter.mustache: servletFilterannotated with@Componentfor Spring Boot auto-registrationREADME.mustache: usage instructions for Spring Boot deploymenthttps://claude.ai/code/session_01T46fG2CEPhy2u1dmcXdEAH
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds a new
jersey3-spring-boot4option to thejaxrs-jerseygenerator to produce a Spring Boot 4 JAR using Jersey 3 and Jakarta EE 11. This lets server stubs run with an embedded server instead of a WAR.New Features
jersey3-spring-boot4registered alongsidejersey2/jersey3.processOpts()switches to Jakarta imports and Swagger2 annotations and generates Spring Boot files instead ofweb.xml/Bootstrap.java.JavaJaxRS/libraries/jersey3-spring-boot4/:pom.mustache(JAR, Spring Boot 4.0.1, Java 17+),SpringBootApplication.mustache,JerseyConfig.mustache,application.mustache,ApiOriginFilter.mustache,README.mustache.Schemaimports for models when using this library.Migration
--library jersey3-spring-boot4; Java 17+ required.mvn spring-boot:runorjava -jar target/<artifact>.jarusingspring-boot-starter-jersey.Written for commit ac9dda1. Summary will update on new commits.