Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,7 @@ public ModelsMap postProcessModels(ModelsMap objs) {
if (useOptional) {
for (ModelMap modelMap : objs.getModels()) {
CodegenModel model = modelMap.getModel();
boolean hasOptionalProperties = false;

boolean shouldUseOptional;

Expand All @@ -636,9 +637,12 @@ public ModelsMap postProcessModels(ModelsMap objs) {
for (CodegenProperty prop : model.vars) {
if (!prop.required && !prop.dataType.startsWith("Optional<")) {
wrapPropertyWithOptional(prop);
hasOptionalProperties = true;
}
}
}

model.vendorExtensions.put("x-has-optional-properties", hasOptionalProperties);
}
}

Expand All @@ -653,13 +657,16 @@ private void wrapPropertyWithOptional(CodegenProperty property) {

boolean hasNullableSuffix = property.dataType.endsWith("?");
String baseType = hasNullableSuffix ? property.dataType.substring(0, property.dataType.length() - 1) : property.dataType;
property.vendorExtensions.put("x-unwrapped-datatype-nullable", baseType + "?");
property.dataType = "Optional<" + baseType + "?" + ">";

if (property.datatypeWithEnum != null && !property.datatypeWithEnum.startsWith("Optional<")) {
hasNullableSuffix = property.datatypeWithEnum.endsWith("?");
baseType = hasNullableSuffix ? property.datatypeWithEnum.substring(0, property.datatypeWithEnum.length() - 1) : property.datatypeWithEnum;
property.datatypeWithEnum = "Optional<" + baseType + "?" + ">";
}

property.isNullable = false;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ export 'package:{{pubName}}/{{sourceFolder}}/auth/api_key_auth.dart';
export 'package:{{pubName}}/{{sourceFolder}}/auth/basic_auth.dart';
export 'package:{{pubName}}/{{sourceFolder}}/auth/bearer_auth.dart';
export 'package:{{pubName}}/{{sourceFolder}}/auth/oauth.dart';
{{#useOptional}}export 'package:{{pubName}}/{{sourceFolder}}/optional.dart';
{{/useOptional}}
{{#useBuiltValue}}export 'package:{{pubName}}/{{sourceFolder}}/serializers.dart';
{{#useDateLibCore}}export 'package:{{pubName}}/{{sourceFolder}}/{{modelPackage}}/date.dart';{{/useDateLibCore}}{{/useBuiltValue}}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import 'package:json_annotation/json_annotation.dart';
/// // Field has value - sends {"field": "value"}
/// final patch3 = Model(field: const Optional.present('value'));
/// ```
sealed class Optional<T> {
abstract class Optional<T> {
const Optional();

/// Creates an Optional with an absent value (not set).
Expand Down Expand Up @@ -48,7 +48,7 @@ sealed class Optional<T> {
}

/// Represents an absent Optional value.
final class Absent<T> extends Optional<T> {
class Absent<T> extends Optional<T> {
const Absent();

@override
Expand Down Expand Up @@ -77,7 +77,7 @@ final class Absent<T> extends Optional<T> {
}

/// Represents a present Optional value.
final class Present<T> extends Optional<T> {
class Present<T> extends Optional<T> {
const Present(this._value);

final T _value;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import 'package:built_value/built_value.dart';
import 'package:built_value/serializer.dart';{{#oneOf}}{{#-first}}
import 'package:one_of/one_of.dart';{{/-first}}{{/oneOf}}{{#anyOf}}{{#-first}}
import 'package:one_of/any_of.dart';{{/-first}}{{/anyOf}}
{{#vendorExtensions.x-has-optional-properties}}import 'package:{{pubName}}/{{sourceFolder}}/optional.dart';
{{/vendorExtensions.x-has-optional-properties}}

{{#imports}}
{{/imports}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
@Deprecated('{{{name}}} has been deprecated')
{{/deprecated}}
@BuiltValueField(wireName: r'{{baseName}}')
{{>serialization/built_value/variable_type}}{{^isNullable}}{{^required}}?{{/required}}{{/isNullable}} get {{name}};
{{>serialization/built_value/variable_type}}{{^vendorExtensions.x-is-optional}}{{^isNullable}}{{^required}}?{{/required}}{{/isNullable}}{{/vendorExtensions.x-is-optional}} get {{name}};
{{#allowableValues}}
// {{#min}}range from {{{min}}} to {{{max}}}{{/min}}{{^min}}enum {{name}}Enum { {{#values}} {{{.}}}, {{/values}} };{{/min}}
{{/allowableValues}}
Expand All @@ -31,8 +31,9 @@
factory {{classname}}([void updates({{classname}}Builder b)]) = _${{classname}};

@BuiltValueHook(initializeBuilder: true)
static void _defaults({{{classname}}}Builder b) => b{{#vendorExtensions.x-parent-discriminator}}..{{propertyName}}=b.discriminatorValue{{/vendorExtensions.x-parent-discriminator}}{{#vendorExtensions.x-self-and-ancestor-only-props}}{{#defaultValue}}
..{{{name}}} = {{#isEnum}}{{^isContainer}}{{#enumName}}{{enumName}}.valueOf({{{defaultValue}}}){{/enumName}}{{^enumName}}{{{defaultValue}}}{{/enumName}}{{/isContainer}}{{/isEnum}}{{^isEnum}}{{{defaultValue}}}{{/isEnum}}{{/defaultValue}}{{/vendorExtensions.x-self-and-ancestor-only-props}};
static void _defaults({{{classname}}}Builder b) => b{{#vendorExtensions.x-parent-discriminator}}..{{propertyName}}=b.discriminatorValue{{/vendorExtensions.x-parent-discriminator}}{{#vendorExtensions.x-self-and-ancestor-only-props}}{{#vendorExtensions.x-is-optional}}
..{{{name}}} = Optional.absent(){{/vendorExtensions.x-is-optional}}{{^vendorExtensions.x-is-optional}}{{#defaultValue}}
..{{{name}}} = {{#isEnum}}{{^isContainer}}{{#enumName}}{{enumName}}.valueOf({{{defaultValue}}}){{/enumName}}{{^enumName}}{{{defaultValue}}}{{/enumName}}{{/isContainer}}{{/isEnum}}{{^isEnum}}{{{defaultValue}}}{{/isEnum}}{{/defaultValue}}{{/vendorExtensions.x-is-optional}}{{/vendorExtensions.x-self-and-ancestor-only-props}};

{{/vendorExtensions.x-is-parent}} @BuiltValueSerializer(custom: true)
static Serializer<{{classname}}> get serializer => _${{classname}}Serializer();
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,21 @@ class _${{classname}}Serializer implements PrimitiveSerializer<{{classname}}> {
FullType specifiedType = FullType.unspecified,
}) sync* {
{{#vendorExtensions.x-self-and-ancestor-only-props}}
{{#vendorExtensions.x-is-optional}}
if (object.{{{name}}}.isPresent) {
yield r'{{baseName}}';
final optionalValue = object.{{{name}}}.value;
if (optionalValue == null) {
yield null;
} else {
yield serializers.serialize(
optionalValue,
specifiedType: const {{>serialization/built_value/variable_serializer_type}},
);
}
}
{{/vendorExtensions.x-is-optional}}
{{^vendorExtensions.x-is-optional}}
{{#required}}
{{!
A required property need to always be part of the serialized output.
Expand All @@ -32,6 +47,7 @@ class _${{classname}}Serializer implements PrimitiveSerializer<{{classname}}> {
);
}
{{/required}}
{{/vendorExtensions.x-is-optional}}
{{/vendorExtensions.x-self-and-ancestor-only-props}}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@
switch (key) {
{{#vendorExtensions.x-self-and-ancestor-only-props}}
case r'{{baseName}}':
{{#vendorExtensions.x-is-optional}}
final valueDes = serializers.deserialize(
value,
specifiedType: const {{>serialization/built_value/variable_serializer_type}},
) as {{{vendorExtensions.x-unwrapped-datatype-nullable}}};
result.{{{name}}} = Optional.present(valueDes);
{{/vendorExtensions.x-is-optional}}
{{^vendorExtensions.x-is-optional}}
final valueDes = serializers.deserialize(
value,
specifiedType: const {{>serialization/built_value/variable_serializer_type}},
Expand Down Expand Up @@ -46,6 +54,7 @@
{{/isModel}}
{{/isEnum}}
{{/isContainer}}
{{/vendorExtensions.x-is-optional}}
break;
{{/vendorExtensions.x-self-and-ancestor-only-props}}
default:
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FullType{{#isNullable}}.nullable{{/isNullable}}({{#isContainer}}{{baseType}}, [{{#isMap}}FullType(String), {{/isMap}}{{#items}}{{>serialization/built_value/variable_serializer_type}}{{/items}}]{{/isContainer}}{{^isContainer}}{{{datatypeWithEnum}}}{{/isContainer}})
{{#vendorExtensions.x-is-optional}}{{#isContainer}}FullType{{#isNullable}}.nullable{{/isNullable}}({{baseType}}, [{{#isMap}}FullType(String), {{/isMap}}{{#items}}{{>serialization/built_value/variable_serializer_type}}{{/items}}]){{/isContainer}}{{^isContainer}}FullType.nullable({{{vendorExtensions.x-unwrapped-datatype}}}){{/isContainer}}{{/vendorExtensions.x-is-optional}}{{^vendorExtensions.x-is-optional}}FullType{{#isNullable}}.nullable{{/isNullable}}({{#isContainer}}{{baseType}}, [{{#isMap}}FullType(String), {{/isMap}}{{#items}}{{>serialization/built_value/variable_serializer_type}}{{/items}}]{{/isContainer}}{{^isContainer}}{{{datatypeWithEnum}}}{{/isContainer}}){{/vendorExtensions.x-is-optional}}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{{#isContainer}}{{baseType}}<{{#isMap}}String, {{/isMap}}{{#items}}{{>serialization/built_value/variable_type}}{{/items}}>{{/isContainer}}{{^isContainer}}{{{datatypeWithEnum}}}{{/isContainer}}{{#isNullable}}?{{/isNullable}}
{{#isContainer}}{{baseType}}<{{#isMap}}String, {{/isMap}}{{#items}}{{>serialization/built_value/variable_type}}{{/items}}>{{/isContainer}}{{^isContainer}}{{{datatypeWithEnum}}}{{/isContainer}}{{#isNullable}}{{^vendorExtensions.x-is-optional}}?{{/vendorExtensions.x-is-optional}}{{/isNullable}}
Loading