Skip to content

fix(cpp-qt-client): #23702 - required members are always present in output of toJsonObject #23703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheZlodziej wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(cpp-qt-client): #23702 - required members are always present in output of toJsonObject #23703

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b2a954
fix(cpp-qt-client): #23702 - required members are always present in o…
TheZlodziej May 6, 2026
94462e3
chore(cpp-qt-client): #23702 - regenerate samples
TheZlodziej May 7, 2026
8b8702c
Merge branch 'OpenAPITools:master' into master
TheZlodziej May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/openapi-generator/src/main/resources/cpp-qt-client/model-body.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ QString {{classname}}::asJson() const {

QJson{{^isEnum}}Object{{/isEnum}}{{#isEnum}}Value{{/isEnum}} {{classname}}::asJson{{^isEnum}}Object{{/isEnum}}{{#isEnum}}Value{{/isEnum}}() const {
{{^isEnum}}QJsonObject obj;{{#vars}}{{^isContainer}}{{#complexType}}
if (m_{{name}}.isSet()){{/complexType}}{{^complexType}}
if (m_{{name}}_isSet){{/complexType}} {
if (true{{^required}} && m_{{name}}.isSet(){{/required}}){{/complexType}}{{^complexType}}
if (true{{^required}} && m_{{name}}_isSet{{/required}}){{/complexType}} {
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Required primitive fields may serialize uninitialized/indeterminate values after this change

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/cpp-qt-client/model-body.mustache, line 104:

<comment>Required primitive fields may serialize uninitialized/indeterminate values after this change</comment>

<file context>
@@ -100,11 +100,11 @@ QString {{classname}}::asJson() const {
-    if (m_{{name}}.isSet()){{/complexType}}{{^complexType}}
-    if (m_{{name}}_isSet){{/complexType}} {
+    if (true{{^required}} && m_{{name}}.isSet(){{/required}}){{/complexType}}{{^complexType}}
+    if (true{{^required}} && m_{{name}}_isSet{{/required}}){{/complexType}} {
         obj.insert(QString("{{baseName}}"), ::{{cppNamespace}}::toJsonValue(m_{{name}}));
     }{{/isContainer}}{{#isContainer}}
</file context>

obj.insert(QString("{{baseName}}"), ::{{cppNamespace}}::toJsonValue(m_{{name}}));
}{{/isContainer}}{{#isContainer}}
if (m_{{name}}.size() > 0) {
if (true{{^required}} && m_{{name}}.size() > 0{{/required}}) {
{{^items.isContainer}}obj.insert(QString("{{baseName}}"), ::{{cppNamespace}}::toJsonValue(m_{{name}}));{{/items.isContainer}}{{#items.isContainer}}
obj.insert(QString("{{baseName}}"), toJsonValue(m_{{name}}));{{/items.isContainer}}
}{{/isContainer}}{{/vars}}
Expand Down
Loading