Skip to content

Commit 9937a9f

Browse files
committed
fix: avoid duplicate agent_run telemetry events
1 parent f94ab4b commit 9937a9f

2 files changed

Lines changed: 2 additions & 51 deletions

File tree

openadapt_evals/cli/main.py

Lines changed: 2 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818

1919
import argparse
2020
import sys
21-
import time
22-
23-
from openadapt_evals.telemetry import track_agent_run, track_agent_run_completed
2421

2522

2623
def main(argv: list[str] | None = None) -> int:
@@ -252,43 +249,13 @@ def _cmd_mock(args: argparse.Namespace) -> int:
252249
"""Run mock evaluation."""
253250
# Delegate to existing CLI implementation
254251
from openadapt_evals.benchmarks.cli import cmd_mock
255-
start = time.perf_counter()
256-
track_agent_run(
257-
phase="start",
258-
entrypoint="oa evals mock",
259-
mode="mock",
260-
agent_class=getattr(args, "agent", "mock"),
261-
)
262-
rc = cmd_mock(args)
263-
track_agent_run_completed(
264-
entrypoint="oa evals mock",
265-
mode="mock",
266-
agent_class=getattr(args, "agent", "mock"),
267-
return_code=rc,
268-
duration_seconds=round(time.perf_counter() - start, 3),
269-
)
270-
return rc
252+
return cmd_mock(args)
271253

272254

273255
def _cmd_run(args: argparse.Namespace) -> int:
274256
"""Run live evaluation."""
275257
from openadapt_evals.benchmarks.cli import cmd_live
276-
start = time.perf_counter()
277-
track_agent_run(
278-
phase="start",
279-
entrypoint="oa evals run",
280-
mode="live",
281-
agent_class=getattr(args, "agent", "unknown"),
282-
)
283-
rc = cmd_live(args)
284-
track_agent_run_completed(
285-
entrypoint="oa evals run",
286-
mode="live",
287-
agent_class=getattr(args, "agent", "unknown"),
288-
return_code=rc,
289-
duration_seconds=round(time.perf_counter() - start, 3),
290-
)
291-
return rc
258+
return cmd_live(args)
292259

293260

294261
def _cmd_probe(args: argparse.Namespace) -> int:

scripts/record_waa_demos.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,6 @@
9595

9696
from openadapt_evals.constants import HARDER_TASK_IDS
9797
from openadapt_evals.telemetry import (
98-
track_agent_run,
99-
track_agent_run_completed,
10098
track_demo_recorded,
10199
)
102100

@@ -2450,22 +2448,8 @@ def cmd_eval_dc(
24502448

24512449
print(f"Running eval-suite with demo-conditioned demos from {demo_dir}")
24522450
print(f"Command: {' '.join(cmd)}\n")
2453-
track_agent_run(
2454-
phase="start",
2455-
entrypoint="record_waa_demos.py eval",
2456-
mode="demo-conditioned",
2457-
num_tasks=len([t.strip() for t in tasks.split(",") if t.strip()]),
2458-
max_steps=max_steps,
2459-
run_name=suite_name,
2460-
)
24612451

24622452
result = subprocess.run(cmd)
2463-
track_agent_run_completed(
2464-
entrypoint="record_waa_demos.py eval",
2465-
mode="demo-conditioned",
2466-
return_code=result.returncode,
2467-
run_name=suite_name,
2468-
)
24692453
if result.returncode != 0:
24702454
sys.exit(result.returncode)
24712455

0 commit comments

Comments
 (0)