fix: add vm_ip to MockEnv in evaluate_server.py#181
Merged
Conversation
WAA getter modules access env.vm_ip to make HTTP calls to the Windows VM. The MockEnv class in evaluate_server.py was missing this attribute, causing getters to crash with AttributeError during evaluation. Add vm_ip (default "172.30.0.2") and port (default 5000) to match the MockEnv in evaluate_endpoint.py and the QEMU guest address used by the PythonController. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vm_ipandportattributes toMockEnvinevaluate_server.py(the evaluate server that runs inside the WAA Docker container)env.vm_ipto make HTTP calls to the Windows VM; the missing attribute causedAttributeErrorcrashes during evaluation172.30.0.2:5000) already used by thePythonControlleron the same lineContext
The
MockEnvinopenadapt_evals/server/evaluate_endpoint.pyalready hadvm_ipandport, but the Docker-sideMockEnvinwaa_deploy/evaluate_server.pywas missing them. Thestart_with_evaluate.shiptables fix (PR #115) is already in place.Test plan
evaluate_server.pystarts without errors inside the WAA containerenv.vm_ip(e.g.,get_vm_command_line)AttributeErroronvm_ipin/tmp/evaluate_server.log🤖 Generated with Claude Code