fix: use systemd-first pattern for socat proxy in record_waa_demos#61
Closed
abrichr wants to merge 1 commit into
Closed
fix: use systemd-first pattern for socat proxy in record_waa_demos#61abrichr wants to merge 1 commit into
abrichr wants to merge 1 commit into
Conversation
Match the pattern from run_dc_eval.py:_setup_eval_proxy — try socat-waa-evaluate.service first (auto-restarts on failure), fall back to legacy nohup for older VMs. Also return False on failure instead of always returning True. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
Member
Author
|
Closing: PR #62 merged with the same socat systemd-first fix plus recording persistence changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_auto_start_socatinrecord_waa_demos.pywas using a legacy nohup-only approach whilerun_dc_eval.py:_setup_eval_proxyalready had the systemd-first patternsocat-waa-evaluate.servicefirst (auto-restarts on failure), falls back to nohup for older VMsFalseon failure instead of always returningTrueContext
This fix was supposed to be part of PR #57 but the PR was merged before the commit was pushed. This is a clean follow-up from main.
Test plan
systemctl restart🤖 Generated with Claude Code