style: clear legacy ruff violations

Author: abrichr

.github/workflows/test.yml

@@ -25,11 +25,7 @@ jobs:
         run: uv sync --extra dev
 
       - name: Ruff
-        run: |
-          uv run ruff check \
-            src/openadapt_telemetry/posthog.py \
-            src/openadapt_telemetry/__init__.py \
-            tests/test_posthog.py
+        run: uv run ruff check .
 
       - name: Pytest
-        run: PYTHONPATH=src uv run pytest -q tests/test_posthog.py
+        run: PYTHONPATH=src uv run pytest -q

src/openadapt_telemetry/client.py

@@ -10,13 +10,12 @@
 import platform
 import sys
 from pathlib import Path
-from typing import Any, Callable, Dict, Optional
+from typing import Any, Dict, Optional
 
 import sentry_sdk
-from sentry_sdk.types import Event, Hint
 
 from .config import TelemetryConfig, load_config
-from .privacy import create_before_send_filter, sanitize_path
+from .privacy import create_before_send_filter
 
 
 def is_running_from_executable() -> bool:

src/openadapt_telemetry/config.py

@@ -15,7 +15,6 @@
 from pathlib import Path
 from typing import Any, Optional
 
-
 # Default configuration values
 DEFAULTS = {
     "enabled": True,

src/openadapt_telemetry/decorators.py

@@ -10,7 +10,7 @@
 
 import functools
 import time
-from typing import Any, Callable, Optional, TypeVar, Union
+from typing import Any, Callable, Optional, TypeVar
 
 import sentry_sdk
 
@@ -57,7 +57,7 @@ def wrapper(*args: Any, **kwargs: Any) -> Any:
                     result = func(*args, **kwargs)
                     transaction.set_status("ok")
                     return result
-                except Exception as e:
+                except Exception:
                     transaction.set_status("internal_error")
                     raise
                 finally:

src/openadapt_telemetry/privacy.py

@@ -12,7 +12,6 @@
 import re
 from typing import Any, Dict, List, Optional, Set
 
-
 # Sensitive field names that should have their values redacted
 PII_DENYLIST: Set[str] = {
     # Authentication

tests/test_client.py

@@ -1,10 +1,7 @@
 """Tests for telemetry client."""
 
 import os
-from pathlib import Path
-from unittest.mock import MagicMock, patch
-
-import pytest
+from unittest.mock import patch
 
 from openadapt_telemetry.client import (
     TelemetryClient,

tests/test_config.py

@@ -9,7 +9,6 @@
 import pytest
 
 from openadapt_telemetry.config import (
-    CONFIG_FILE,
     TelemetryConfig,
     _get_env_config,
     _load_config_file,

tests/test_decorators.py

@@ -1,6 +1,5 @@
 """Tests for telemetry decorators."""
 
-import os
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -171,20 +170,20 @@ def teardown_method(self):
 
     def test_basic_usage(self):
         """Basic span usage should work."""
-        with TelemetrySpan("test_op", "test_span") as span:
+        with TelemetrySpan("test_op", "test_span"):
             result = 1 + 1
 
         assert result == 2
 
     def test_with_description(self):
         """Span with description should work."""
-        with TelemetrySpan("op", "name", description="Test description") as span:
+        with TelemetrySpan("op", "name", description="Test description"):
             pass
 
     def test_exception_handling(self):
         """Exceptions should propagate through span."""
         with pytest.raises(ValueError, match="test"):
-            with TelemetrySpan("op", "name") as span:
+            with TelemetrySpan("op", "name"):
                 raise ValueError("test")
 
     def test_set_tag(self):

tests/test_privacy.py

@@ -1,6 +1,5 @@
 """Tests for privacy filtering and PII scrubbing."""
 
-import pytest
 
 from openadapt_telemetry.privacy import (
     is_sensitive_key,