fix: avoid misclassifying non-binary users as internal

Author: abrichr

src/openadapt_telemetry/client.py

@@ -59,9 +59,8 @@ def is_internal_user() -> bool:
     Uses multiple heuristics to detect internal/developer usage:
     1. Explicit OPENADAPT_INTERNAL environment variable
     2. OPENADAPT_DEV environment variable
-    3. Not running from frozen executable
-    4. Git repository present in current directory
-    5. CI environment detected
+    3. Git repository present in current directory
+    4. CI environment detected
 
     Returns:
         True if this appears to be internal usage.
@@ -74,15 +73,11 @@ def is_internal_user() -> bool:
     if os.getenv("OPENADAPT_DEV", "").lower() in ("true", "1", "yes"):
         return True
 
-    # Method 3: Not running from executable (indicates dev mode)
-    if not is_running_from_executable():
-        return True
-
-    # Method 4: Git repository present (development checkout)
+    # Method 3: Git repository present (development checkout)
     if Path(".git").exists() or Path("../.git").exists():
         return True
 
-    # Method 5: CI/CD environment
+    # Method 4: CI/CD environment
     if is_ci_environment():
         return True
 

tests/test_client.py

@@ -96,6 +96,13 @@ def test_ci_indicates_internal(self):
         with patch.dict(os.environ, {"CI": "true"}, clear=False):
             assert is_internal_user() is True
 
+    @patch("openadapt_telemetry.client.Path.exists", return_value=False)
+    @patch("openadapt_telemetry.client.is_ci_environment", return_value=False)
+    def test_no_signals_indicates_external(self, _mock_ci, _mock_exists):
+        """Without explicit internal signals, usage should be treated as external."""
+        with patch.dict(os.environ, {"OPENADAPT_INTERNAL": "", "OPENADAPT_DEV": ""}, clear=False):
+            assert is_internal_user() is False
+
 
 class TestTelemetryClient:
     """Tests for TelemetryClient class."""