Commit b0899fa
committed
[Build] Fix incorrect Version metadata in dist-info
Closes #123.
The CMake script has the ability to simulate a Python package
installation, such that a `dist-info` metadata directory is installed
alongside the package, effectively preventing accidental overwrite by
other package managers (e.g. pip) when the project is installed via
CMake - see #58.
However, the `Version` field in the `METADATA` file that forms part
of the Python package `dist-info` was not being properly filled in.
This was not caught by CI because the test for it is only enabled if
generation of Python traits via CMake is enabled (i.e.
`OPENASSETIO_MEDIACREATION_GENERATE_PYTHON`), which was not the case
for the "test" CMake preset used by the "Test Cpp" CI job.
There was another problem with running the test, in that the PYTHONPATH
was not properly set in the CMake test target, and so the test would not
necessarily be able to locate the `openassetio-mediacreation` package
installed by CMake.
Signed-off-by: David Feltell <david.feltell@foundry.com>1 parent 37192e9 commit b0899fa
4 files changed
Lines changed: 8 additions & 8 deletions
File tree
- .github/workflows
- cmake/packaging/python.dist-info
- tests/cpp
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
49 | 52 | | |
50 | 53 | | |
51 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | 20 | | |
26 | 21 | | |
27 | 22 | | |
28 | 23 | | |
29 | 24 | | |
30 | | - | |
| 25 | + | |
| 26 | + | |
31 | 27 | | |
32 | 28 | | |
33 | 29 | | |
| |||
0 commit comments