Commit 5723b02
committed
[Build] Set a default build type of Release
The default is toolchain-specific (i.e. CMake generator-specific) and
this can cause unexpected errors.
E.g. if we've installed Python as a Release library, but this project is
built as a Debug library, then on Windows we'll try to link to
`python39_d`, i.e. the debug lib, which may not exist.
We could enforce that `CMAKE_BUILD_TYPE` is always set externally,
however if we forget then builds might just work, but then fail
unexpectedly if we swap the toolchain.
So better to just be consistent and default to Release in all cases,
unless explicitly overridden.
Signed-off-by: David Feltell <david.feltell@foundry.com>1 parent 27e5926 commit 5723b02
1 file changed
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
7 | 21 | | |
| 22 | + | |
8 | 23 | | |
9 | 24 | | |
10 | 25 | | |
| |||
0 commit comments