You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
refactor: Remove unnecessary enum value assignments from CommandFamily
Remove character literal assignments from CommandFamily enum values.
These were never used functionally - the enum serves purely as a
type-safe categorization, while identify_family() does the actual
character-to-family mapping.
Benefits:
- Simpler and more idiomatic C++ (compiler auto-assigns 0,1,2...)
- More accurate: Backlash/SmartDrive aren't single characters
- Clearer intent: enum is for type safety, not character storage
- Smaller and more cache-friendly with sequential values
The character mappings are documented in comments and implemented
in identify_family() where they actually matter.
All 103 tests still passing (25+51+17+10).
0 commit comments