Address PR review feedback

Author: Eric Schubert

Configuration.hpp

@@ -73,6 +73,12 @@
     #ifndef INFO_DISPLAY_I2C_SCL_PIN
         #define INFO_DISPLAY_I2C_SCL_PIN 4
     #endif
+    #ifndef INFO_DISPLAY_UPSIDE_DOWN
+        #define INFO_DISPLAY_UPSIDE_DOWN 0
+    #endif
+    #ifndef INFO_DISPLAY_MIRRORED
+        #define INFO_DISPLAY_MIRRORED 0
+    #endif
 #endif
 
 // Used RA wheel version. Unless you printed your OAT before March 2020, you're using
@@ -266,12 +272,10 @@
     #include "boards/AVR_MKS_GEN_L_V2/pins_MKS_GEN_L_V2.h"
 #elif (BOARD == BOARD_AVR_MKS_GEN_L_V21)
     #include "boards/AVR_MKS_GEN_L_V21/pins_MKS_GEN_L_V21.h"
-#elif (BOARD == BOARD_RP2040_JACKW01) || (BOARD == BOARD_RP2350_JACKW01)
+#elif (BOARD == BOARD_RP2040_JACKW01)
     #include "boards/RP2040_JACKW01/pins_RP2040_JACKW01.hpp"
 #elif (BOARD == BOARD_RP2040_SKR_PICO)
     #include "boards/RP2040_SKR_PICO/pins_RP2040_SKR_PICO.hpp"
-#elif (BOARD == BOARD_RP2040_PICO) || (BOARD == BOARD_RP2350_PICO2)
-    #include "boards/RP2040_PICO/pins_RP2040_PICO.hpp"
 #endif
 
 #include "Configuration_adv.hpp"

ConfigurationValidation.hpp

@@ -112,6 +112,9 @@
         #endif
     #endif
 
+#elif defined(OAE)
+// Valid
+
 #else
     #warning Configuration does not support ALT. Use at own risk.
 #endif
@@ -228,7 +231,7 @@
 #if (AZ_STEPPER_TYPE != STEPPER_TYPE_NONE)
     #if (AZ_DRIVER_TYPE == DRIVER_TYPE_A4988_GENERIC) || (AZ_DRIVER_TYPE == DRIVER_TYPE_TMC2209_STANDALONE)
         #if !defined(AZ_STEP_PIN) || !defined(AZ_DIR_PIN) || !defined(AZ_EN_PIN) || !defined(AZ_DIAG_PIN)
-            // Required pin assignments missing
+            // Required pin assignments missing (ATmega uses SoftwareSerial for this driver)
             #error Missing pin assignments for configured AZ DRIVER_TYPE_A4988_GENERIC or DRIVER_TYPE_TMC2209_STANDALONE driver
         #endif
     #elif (AZ_DRIVER_TYPE == DRIVER_TYPE_TMC2209_UART)
@@ -252,7 +255,7 @@
 #if (ALT_STEPPER_TYPE != STEPPER_TYPE_NONE)
     #if (ALT_DRIVER_TYPE == DRIVER_TYPE_A4988_GENERIC) || (ALT_DRIVER_TYPE == DRIVER_TYPE_TMC2209_STANDALONE)
         #if !defined(ALT_STEP_PIN) || !defined(ALT_DIR_PIN) || !defined(ALT_EN_PIN) || !defined(ALT_DIAG_PIN)
-            // Required pin assignments missing
+            // Required pin assignments missing (ATmega uses SoftwareSerial for this driver)
             #error Missing pin assignments for configured AZ DRIVER_TYPE_A4988_GENERIC or DRIVER_TYPE_TMC2209_STANDALONE driver
         #endif
     #elif (ALT_DRIVER_TYPE == DRIVER_TYPE_TMC2209_UART)
@@ -463,7 +466,7 @@
     #endif
 #endif
 
-// For OAT, we must have DEC limits defined, otherwise free slew does nto work.
+// For OAT, we must have DEC limits defined, otherwise free slew does not work.
 #ifndef OAM
     #ifndef DEC_LIMIT_UP
         #error "You must set DEC_LIMIT_UP to the number of degrees that your OAT can move upwards from the home position."

Constants.hpp

@@ -19,14 +19,10 @@
 // ESP32 based boards
 #define BOARD_ESP32_ESP32DEV 1001
 
-// RP2040/RP2350 based boards (2000-2999)
-//   2001-2099: Generic bare Pico family (user-defined wiring) -- NOT YET SUPPORTED
+// RP2040 based boards (2000-2999)
 //   2101-2199: Pico family + JackW01 printer carrier board
 //   2201-2299: BTT SKR Pico family
-// #define BOARD_RP2040_PICO      2001  // NOT YET SUPPORTED: requires user-defined pin wiring in local config
-// #define BOARD_RP2350_PICO2     2002  // NOT YET SUPPORTED: requires user-defined pin wiring in local config
 #define BOARD_RP2040_JACKW01   2101  // Raspberry Pi Pico (RP2040) + JackW01 printer board
-#define BOARD_RP2350_JACKW01   2102  // Raspberry Pi Pico 2 (RP2350) + JackW01 printer board
 #define BOARD_RP2040_SKR_PICO  2201  // Raspberry Pi Pico (RP2040) on BTT SKR Pico v1.0
 
 /**

LocalConfiguration.hpp

@@ -18,14 +18,8 @@
     #include "Configuration_local_esp32dev.hpp"
 #elif BOARD == BOARD_RP2040_JACKW01 && __has_include("Configuration_local_rp2040_jackw01.hpp")
     #include "Configuration_local_rp2040_jackw01.hpp"
-#elif BOARD == BOARD_RP2350_JACKW01 && __has_include("Configuration_local_rp2350_jackw01.hpp")
-    #include "Configuration_local_rp2350_jackw01.hpp"
 #elif BOARD == BOARD_RP2040_SKR_PICO && __has_include("Configuration_local_rp2040_skr_pico.hpp")
     #include "Configuration_local_rp2040_skr_pico.hpp"
-// #elif BOARD == BOARD_RP2040_PICO && __has_include("Configuration_local_rp2040_pico.hpp")  // NOT YET SUPPORTED
-//     #include "Configuration_local_rp2040_pico.hpp"
-// #elif BOARD == BOARD_RP2350_PICO2 && __has_include("Configuration_local_rp2350_pico2.hpp")  // NOT YET SUPPORTED
-//     #include "Configuration_local_rp2350_pico2.hpp"
 #elif __has_include("Configuration_local.hpp")
     #include "Configuration_local.hpp"
 #endif

platformio.ini

@@ -13,7 +13,7 @@ lib_deps =
 	arduino-libraries/LiquidCrystal @ ^1.0.7
 	lincomatic/LiquidTWI2@^1.2.7
 	olikraus/U8g2@^2.28.8
-	https://github.com/ClutchplateDude/esp8266-oled-ssd1306@4.6.0
+	https://github.com/ClutchplateDude/esp8266-oled-ssd1306#4.6.2
 
 [env]
 extra_scripts =
@@ -95,7 +95,7 @@ debug_build_flags =
 lib_deps = 
 	${common.lib_deps}
 	jdolinay/avr-debugger @ 1.2
-	https://github.com/andre-stefanov/avr-interrupt-stepper@0.0.4
+	https://github.com/andre-stefanov/avr-interrupt-stepper#0.0.4
 
 [env:mksgenlv21]
 extends = env:ramps
@@ -136,8 +136,7 @@ extends = common_embedded
 platform = https://github.com/maxgerhardt/platform-raspberrypi.git
 board_build.core = earlephilhower
 lib_deps =
-	;teemuatlut/TMCStepper @ ^0.7.1 ;Placeholder for if/when changes get merged with official repository code
-	https://github.com/EricSchubert/TMCStepper-RP2040_Support.git#rp2040-single-wire-uart ;
+	teemuatlut/TMCStepper @ ^0.7.1
 	waspinator/AccelStepper @ ^1.61
 	mikalhart/TinyGPSPlus @ ^1.0.2
 ; TimerInterrupt is AVR-only (uses OCR1A etc.); RP2040 uses hardware/timer.h directly
@@ -150,13 +149,6 @@ build_flags =
 	${env.build_flags}
 	-D BOARD=BOARD_RP2040_JACKW01
 
-[env:rp2350_jackw01]
-extends = common_rp2xxx
-board = rpipico2
-build_flags =
-	${env.build_flags}
-	-D BOARD=BOARD_RP2350_JACKW01
-
 [env:rp2040_skr_pico]
 extends = common_rp2xxx
 board = rpipico