fix: early return if an exception is thrown while command parsing#111
Merged
Conversation
According the documentation of CLI11, this library will throw a exception while encounter -h,--help or a parse error. Signed-off-by: ComixHe <ComixHe1895@outlook.com>
|
Here's the code health analysis summary for commits Analysis Summary
|
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
Comment on lines
112
to
+114
| } catch (const CLI::ParseError &e) { | ||
| options.global.return_code = app.exit(e); | ||
| return options; |
There was a problem hiding this comment.
The error handling in the catch block uses app.exit(e) to set the return code and handle the exception. While this centralizes error handling, it's important to ensure that this method provides adequate user feedback and error logging. If app.exit(e) does not log errors or inform the user appropriately, consider enhancing its implementation or adding additional logging before exiting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According the documentation of CLI11, this library will throw a exception while encounter -h,--help or a parse error.