Skip to content

fix: explicitly cast MS_NOUSER to unsigned int #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ComixHe merged 1 commit into from
Oct 21, 2025
Merged

fix: explicitly cast MS_NOUSER to unsigned int #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 32 additions & 28 deletions src/linyaps_box/container.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,38 +121,42 @@

struct MountFlag
{
// mount flag should be unsigned int due to MS_NOUSER (1U << 31)
unsigned int flag;

Check warning on line 124 in src/linyaps_box/container.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

struct member 'MountFlag::flag' is never used.
std::string_view name;

Check warning on line 125 in src/linyaps_box/container.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

struct member 'MountFlag::name' is never used.
};

constexpr std::array<MountFlag, 27> mount_flags{ MountFlag{ MS_RDONLY, "MS_RDONLY" },
{ MS_NOSUID, "MS_NOSUID" },
{ MS_NODEV, "MS_NODEV" },
{ MS_NOEXEC, "MS_NOEXEC" },
{ MS_SYNCHRONOUS, "MS_SYNCHRONOUS" },
{ MS_REMOUNT, "MS_REMOUNT" },
{ MS_MANDLOCK, "MS_MANDLOCK" },
{ MS_DIRSYNC, "MS_DIRSYNC" },
{ LINGYAPS_MS_NOSYMFOLLOW, "MS_NOSYMFOLLOW" },
{ MS_NOATIME, "MS_NOATIME" },
{ MS_NODIRATIME, "MS_NODIRATIME" },
{ MS_BIND, "MS_BIND" },
{ MS_MOVE, "MS_MOVE" },
{ MS_REC, "MS_REC" },
{ MS_SILENT, "MS_SILENT" },
{ MS_POSIXACL, "MS_POSIXACL" },
{ MS_UNBINDABLE, "MS_UNBINDABLE" },
{ MS_PRIVATE, "MS_PRIVATE" },
{ MS_SLAVE, "MS_SLAVE" },
{ MS_SHARED, "MS_SHARED" },
{ MS_RELATIME, "MS_RELATIME" },
{ MS_KERNMOUNT, "MS_KERNMOUNT" },
{ MS_I_VERSION, "MS_I_VERSION" },
{ MS_STRICTATIME, "MS_STRICTATIME" },
{ MS_LAZYTIME, "MS_LAZYTIME" },
{ MS_ACTIVE, "MS_ACTIVE" },
{ MS_NOUSER, "MS_NOUSER" } };
constexpr std::array<MountFlag, 27> mount_flags{
MountFlag{ MS_RDONLY, "MS_RDONLY" },
{ MS_NOSUID, "MS_NOSUID" },
{ MS_NODEV, "MS_NODEV" },
{ MS_NOEXEC, "MS_NOEXEC" },
{ MS_SYNCHRONOUS, "MS_SYNCHRONOUS" },
{ MS_REMOUNT, "MS_REMOUNT" },
{ MS_MANDLOCK, "MS_MANDLOCK" },
{ MS_DIRSYNC, "MS_DIRSYNC" },
{ LINGYAPS_MS_NOSYMFOLLOW, "MS_NOSYMFOLLOW" },
{ MS_NOATIME, "MS_NOATIME" },
{ MS_NODIRATIME, "MS_NODIRATIME" },
{ MS_BIND, "MS_BIND" },
{ MS_MOVE, "MS_MOVE" },
{ MS_REC, "MS_REC" },
{ MS_SILENT, "MS_SILENT" },
{ MS_POSIXACL, "MS_POSIXACL" },
{ MS_UNBINDABLE, "MS_UNBINDABLE" },
{ MS_PRIVATE, "MS_PRIVATE" },
{ MS_SLAVE, "MS_SLAVE" },
{ MS_SHARED, "MS_SHARED" },
{ MS_RELATIME, "MS_RELATIME" },
{ MS_KERNMOUNT, "MS_KERNMOUNT" },
{ MS_I_VERSION, "MS_I_VERSION" },
{ MS_STRICTATIME, "MS_STRICTATIME" },
{ MS_LAZYTIME, "MS_LAZYTIME" },
{ MS_ACTIVE, "MS_ACTIVE" },
// MS_NOUSER will be overflowed before 2.42.9000
// refer:
// https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=3263675250cbcbbcc76ede4f7c660418bd345a11;hp=cd335350021fd0b7ac533c83717ee38832fd9887
{ static_cast<unsigned int>(MS_NOUSER), "MS_NOUSER" }
};

[[maybe_unused]] auto dump_mount_flags(unsigned long flags) noexcept -> std::string
{
Expand Down