fix(tty): set initial console size before exec#180
Merged
Conversation
When config.json omits process.consoleSize the container pty kept its default 0x0 until the first SIGWINCH, so early reads of TIOCGWINSZ (e.g. `stty size`) returned zeros. Resize the master from the host terminal right after receiving its fd, before the child execs, so the initial size is always correct. consoleSize, when set, is still honored by the in-container slave.set_size(). Signed-off-by: Yuming He <ComixHe1895@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When config.json omits process.consoleSize the container pty kept its default 0x0 until the first SIGWINCH, so early reads of TIOCGWINSZ (e.g.
stty size) returned zeros. Resize the master from the host terminal right after receiving its fd, before the child execs, so the initial size is always correct. consoleSize, when set, is still honored by the in-container slave.set_size().