fix(exec): set initial console size before nsenter exec#181
Merged
Conversation
The child's slave.set_size({}) after setsid was a no-op
(/dev/tty == slave, reads 0x0 writes 0x0) so the pty stayed at
0x0 until the first SIGWINCH. Drop it and only set size when
consoleSize is given. On the parent side, after receiving the
master fd, resize it from the host terminal before attaching
(unless consoleSize was set). Accept the small race window:
the parent's single ioctl lands within the child's
send_fd→execvpe window in practice.
Signed-off-by: Yuming He <ComixHe1895@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The child's slave.set_size({}) after setsid was a no-op (/dev/tty == slave, reads 0x0 writes 0x0) so the pty stayed at 0x0 until the first SIGWINCH. Drop it and only set size when consoleSize is given. On the parent side, after receiving the master fd, resize it from the host terminal before attaching (unless consoleSize was set). Accept the small race window: the parent's single ioctl lands within the child's send_fd→execvpe window in practice.