Skip to content

chore: run pre-commit on all files#1558

Merged
ComixHe merged 1 commit into
OpenAtom-Linyaps:masterfrom
ComixHe:master
Jan 15, 2026
Merged

chore: run pre-commit on all files#1558
ComixHe merged 1 commit into
OpenAtom-Linyaps:masterfrom
ComixHe:master

Conversation

@ComixHe

@ComixHe ComixHe commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ComixHe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve code quality and maintain consistency across the repository by running pre-commit hooks on all relevant files. The changes include updating the pre-commit configuration to refine exclusions, enhancing the libfuse patch for more adaptable fusermount executable detection, and applying widespread formatting adjustments such as trailing whitespace removal and JSON reformatting throughout the codebase. These efforts ensure a cleaner and more standardized code style.

Highlights

  • Pre-commit Configuration Update: The .pre-commit-config.yaml file has been updated to include new exclusion paths, specifically for .obs/ and misc/share/linglong/builder/templates/, preventing pre-commit hooks from running on these directories.
  • Flexible fusermount Path Resolution: The libfuse.patch in apps/ll-builder-utils was modified to dynamically resolve the fusermount executable path using a new fusermountProg() function, enhancing flexibility and environment adaptability.
  • Extensive Codebase Formatting: Numerous files across various directories, including C++ source, test data (JSON/YAML), shell scripts, and translation files, have undergone significant formatting changes, primarily involving whitespace removal and JSON reformatting, consistent with applying pre-commit hooks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request applies pre-commit hooks across the repository, resulting in numerous formatting and whitespace fixes. The changes are mostly beneficial for code consistency.

However, I've identified two potential issues in the test data JSON files that were modified:

  • In libs/linglong/tests/ll-tests/data/demo/config.json, a duplicate root key was removed. This is a significant logical change that needs verification to ensure tests are not broken.
  • In libs/linglong/tests/ll-tests/data/demo/config-mini.json, there are duplicate mount entries for /etc which should probably be cleaned up.

Please review these specific comments. The rest of the changes look good.

I am having trouble creating individual review comments. Click here to see my feedback.

libs/linglong/tests/ll-tests/data/demo/config.json (378-381)

critical

The pre-commit hook removed a duplicate root key from this JSON file. While this fixes the invalid JSON syntax, it's a significant logical change. The removed root object had path: "/run/user/1000/linglong/ab24ae64edff4ddfa8e6922eb29e2baf" and readonly: false, while the kept root object has path: "rootfs" and readonly: true. Please verify that this change is correct and doesn't break any tests that rely on this configuration file.

libs/linglong/tests/ll-tests/data/demo/config-mini.json (119-124)

medium

While reformatting this file, I noticed that the mounts array contains duplicate entries for the destination /etc. This might be a copy-paste error and could lead to unexpected behavior in tests. It would be best to remove the redundant entry if it's not intentional.

Signed-off-by: ComixHe <ComixHe1895@outlook.com>
@ComixHe ComixHe merged commit e74db0b into OpenAtom-Linyaps:master Jan 15, 2026
12 checks passed
@codecov

codecov Bot commented Jan 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/ll-driver-detect/src/dbus_notifier.cpp 0.00% 14 Missing ⚠️
...ps/ll-driver-detect/src/driver_detection_manager.h 0.00% 3 Missing ⚠️
...ps/ll-driver-detect/src/nvidia_driver_detector.cpp 0.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
...pps/ll-driver-detect/src/application_singleton.cpp 38.23% <ø> (ø)
...ps/ll-driver-detect/src/nvidia_driver_detector.cpp 22.72% <0.00%> (ø)
...ps/ll-driver-detect/src/driver_detection_manager.h 20.00% <0.00%> (+3.33%) ⬆️
apps/ll-driver-detect/src/dbus_notifier.cpp 2.29% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant