Skip to content

fix: exit when erofsfuse_main return #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dengbo11 merged 1 commit into from
Jan 27, 2026
Merged

fix: exit when erofsfuse_main return #1570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/uab/header/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ int mountSelfBundle(const lightElf::native_elf &elf,
}
}

return erofsfuse_main(4, const_cast<char **>(erofs_argv.data()));
_exit(erofsfuse_main(4, const_cast<char **>(erofs_argv.data())));

@gemini-code-assist gemini-code-assist Bot Jan 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using _exit is crucial here to prevent the child process from running any further code after erofsfuse_main completes. This avoids potential conflicts or unintended side effects in the parent process's environment. This is especially important in forked processes to avoid shared resource corruption or double freeing of memory.

Consider adding a comment explaining why _exit is used instead of exit or return for clarity.

Suggested change
_exit(erofsfuse_main(4, const_cast<char **>(erofs_argv.data())));
_exit(erofsfuse_main(4, const_cast<char **>(erofs_argv.data()))); // Use _exit to avoid parent process interference

}

int status{ 0 };
Expand Down