Skip to content

fix: replace Q_ASSERT with proper error handling #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dengbo11 merged 1 commit into from
Mar 4, 2026
Merged

fix: replace Q_ASSERT with proper error handling #1601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libs/linglong/src/linglong/package/layer_packager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ LayerPackager::pack(const LayerDir &dir, const QString &layerFilePath) const
}

auto result = LayerFile::New(layerFilePath);
Q_ASSERT(result.has_value());
if (!result) {
return LINGLONG_ERR(result);
}

return result;
Comment on lines 168 to 173

@gemini-code-assist gemini-code-assist Bot Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the current error handling is correct, it can be made more concise by using map_error from tl::expected. This avoids the explicit if block and intermediate variable, making the intent of wrapping the error and returning clearer.

    return LayerFile::New(layerFilePath).map_error([&](auto &&err) {
        return LINGLONG_ERRV(std::move(err));
    });

}
Expand Down
Loading